From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: [PATCH] mini-os: Fix stubdom build failures on gcc 4.8 Date: Wed, 22 Jan 2014 18:19:06 +0100 Message-ID: <20140122171906.GT8171@type> References: <1390410769-2517-1-git-send-email-xenmail43267@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1390410769-2517-1-git-send-email-xenmail43267@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xenmail43267@gmail.com Cc: Ian.Campbell@citrix.com, andrew.cooper3@citrix.com, xen-devel@lists.xen.org, Mike Neilsen , stefano.stabellini@citrix.com, alex.sharp@orionvm.com List-Id: xen-devel@lists.xenproject.org xenmail43267@gmail.com, le Wed 22 Jan 2014 11:12:49 -0600, a =E9crit : > index 16a4b49..ce5180c 100644 > --- a/extras/mini-os/pcifront.c > +++ b/extras/mini-os/pcifront.c > @@ -424,7 +424,7 @@ int pcifront_physical_to_virtual (struct pcifront_dev= *dev, > continue; > } > = > - if (sscanf(s, "%x:%x:%x.%x", dom, bus, slot, fun) !=3D 4) { > + if (sscanf(s, "%x:%x:%x.%lx", dom, bus, slot, fun) !=3D 4) { > printk("\"%s\" does not look like a PCI device address\n= ", s); > free(s); > continue; Rather make fun an unsigned int, there is no reason why it should be an unsigned long, I'm still wondering where that comes from. There rest seems OK to me.