From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from top.free-electrons.com ([176.31.233.9]:47909 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752867AbaAVSDn (ORCPT ); Wed, 22 Jan 2014 13:03:43 -0500 Date: Wed, 22 Jan 2014 15:03:58 -0300 From: Ezequiel Garcia To: Jason Gunthorpe Cc: Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, Lior Amsalem , Thomas Petazzoni , Jason Cooper , Tawfik Bayouk , Andrew Lunn , Wim Van Sebroeck , Gregory Clement Subject: Re: [PATCH v2 06/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Message-ID: <20140122180357.GF27273@localhost> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-7-git-send-email-ezequiel.garcia@free-electrons.com> <20140121233537.GS18269@obsidianresearch.com> <20140122164904.GB27273@localhost> <20140122173417.GT18269@obsidianresearch.com> <20140122174539.GD27273@localhost> <20140122175030.GU18269@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: <20140122175030.GU18269@obsidianresearch.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Wed, Jan 22, 2014 at 10:50:30AM -0700, Jason Gunthorpe wrote: > On Wed, Jan 22, 2014 at 02:45:40PM -0300, Ezequiel Garcia wrote: > =20 > > Agreed. So, let's assume we can guarantee that request_irq() does t= he > > job of clearing the cause register (clearing pending irqs). > >=20 > > So, your suggestion is to put request_irq() in the watchdog start()= ? > >=20 > > Otherwise, we can ensure a watchdog full stop at probe(), before > > requesting the IRQ. Both solutions should work, uh? >=20 > Right, I would keep the request_irq in probe, just because that feels > more idiomatic.. >=20 Done. Baking v4... --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Wed, 22 Jan 2014 15:03:58 -0300 Subject: [PATCH v2 06/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear In-Reply-To: <20140122175030.GU18269@obsidianresearch.com> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-7-git-send-email-ezequiel.garcia@free-electrons.com> <20140121233537.GS18269@obsidianresearch.com> <20140122164904.GB27273@localhost> <20140122173417.GT18269@obsidianresearch.com> <20140122174539.GD27273@localhost> <20140122175030.GU18269@obsidianresearch.com> Message-ID: <20140122180357.GF27273@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 22, 2014 at 10:50:30AM -0700, Jason Gunthorpe wrote: > On Wed, Jan 22, 2014 at 02:45:40PM -0300, Ezequiel Garcia wrote: > > > Agreed. So, let's assume we can guarantee that request_irq() does the > > job of clearing the cause register (clearing pending irqs). > > > > So, your suggestion is to put request_irq() in the watchdog start()? > > > > Otherwise, we can ensure a watchdog full stop at probe(), before > > requesting the IRQ. Both solutions should work, uh? > > Right, I would keep the request_irq in probe, just because that feels > more idiomatic.. > Done. Baking v4... -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2 06/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Date: Wed, 22 Jan 2014 15:03:58 -0300 Message-ID: <20140122180357.GF27273@localhost> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-7-git-send-email-ezequiel.garcia@free-electrons.com> <20140121233537.GS18269@obsidianresearch.com> <20140122164904.GB27273@localhost> <20140122173417.GT18269@obsidianresearch.com> <20140122174539.GD27273@localhost> <20140122175030.GU18269@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140122175030.GU18269-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Sebastian Hesselbarth , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lior Amsalem , Thomas Petazzoni , Jason Cooper , Tawfik Bayouk , Andrew Lunn , Wim Van Sebroeck , Gregory Clement List-Id: devicetree@vger.kernel.org On Wed, Jan 22, 2014 at 10:50:30AM -0700, Jason Gunthorpe wrote: > On Wed, Jan 22, 2014 at 02:45:40PM -0300, Ezequiel Garcia wrote: > =20 > > Agreed. So, let's assume we can guarantee that request_irq() does t= he > > job of clearing the cause register (clearing pending irqs). > >=20 > > So, your suggestion is to put request_irq() in the watchdog start()= ? > >=20 > > Otherwise, we can ensure a watchdog full stop at probe(), before > > requesting the IRQ. Both solutions should work, uh? >=20 > Right, I would keep the request_irq in probe, just because that feels > more idiomatic.. >=20 Done. Baking v4... --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html