From: David Cohen <david.a.cohen@linux.intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Fei Yang <fei.yang@intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH] x86: don't add new __cpuinit users to Merrifield platform code
Date: Wed, 22 Jan 2014 10:08:03 -0800 [thread overview]
Message-ID: <20140122180803.GA25171@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <1390412125-19439-1-git-send-email-paul.gortmaker@windriver.com>
On Wed, Jan 22, 2014 at 12:35:25PM -0500, Paul Gortmaker wrote:
> Commit bc20aa48bbb3068224a1c91f8332971fdb689fad ("x86, intel-mid:
> Add Merrifield platform support") added new instances of __cpuinit
> usage. We removed this a couple versions ago; we now want to remove
> the compat no-op stubs. Introducing new users is not what we want to
> see at this point in time, as it will break once the stubs are gone.
>
> This also fixes an out of sync __init vs. __cpuinit -- as the former
> is real, and the latter is a no-op; hence it would have been a section
> mismatch.
>
> Cc: David Cohen <david.a.cohen@linux.intel.com>
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: H. Peter Anvin <hpa@linux.intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thanks for the patch.
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
next prev parent reply other threads:[~2014-01-22 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 17:35 [PATCH] x86: don't add new __cpuinit users to Merrifield platform code Paul Gortmaker
2014-01-22 18:08 ` David Cohen [this message]
2014-01-22 18:09 ` David Cohen
2014-01-22 22:23 ` H. Peter Anvin
2014-01-22 22:33 ` David Cohen
2014-01-22 22:30 ` [tip:x86/intel-mid] x86: Don' t " tip-bot for Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122180803.GA25171@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=fei.yang@intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.