From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: IGT conventions Date: Wed, 22 Jan 2014 21:53:42 +0100 Message-ID: <20140122205342.GL9772@phenom.ffwll.local> References: <20140115232628.GC14542@jeffdesk> <20140115235516.GB4770@phenom.ffwll.local> <20140116164336.GD14542@jeffdesk> <20140122204041.GG14542@jeffdesk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 07EBAFBC49 for ; Wed, 22 Jan 2014 12:53:46 -0800 (PST) Received: by mail-ee0-f41.google.com with SMTP id e49so25154eek.28 for ; Wed, 22 Jan 2014 12:53:46 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140122204041.GG14542@jeffdesk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 22, 2014 at 02:40:42PM -0600, Jeff McGee wrote: > There doesn't seem to be anything like the exit handlers for running when > a subtest exits. I need a failed subtest to be able to cleanup after > itself to avoid contaminating subsequent subtests. Have I missed something? > Perhaps this is not a problem when running subtests individually through > piglit? Yeah, the exit handlers only clean up when the entire test goes down, not after each failed subtest. If you want more reliability you need to run all the subtests individually (and maybe you even need to restart the machine if something particularly bad happens). > I guess one simple approach is to wrap igt_assert with the cleanup > function, like the restore_assert that was originally used in pm_rps. tbh I'm not sure whether this is worth catering for - imo better to invest that time into getting a real android/igt testrunner going. For development you can just run individual subtest only when hacking around, for regression testing nothing really should fail after all ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch