From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 3/6] drm/radeon: Use new drm debugfs file helper Date: Wed, 22 Jan 2014 19:20:43 -0800 Message-ID: <20140123032042.GA2588@bwidawsk.net> References: <1389708847-25038-1-git-send-email-benjamin.widawsky@intel.com> <1390336402-2049-1-git-send-email-benjamin.widawsky@intel.com> <1390336402-2049-3-git-send-email-benjamin.widawsky@intel.com> <52DF993E.6070203@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 8521BFB43C for ; Wed, 22 Jan 2014 19:21:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <52DF993E.6070203@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Christian =?utf-8?B?S8O2bmln?= Cc: DRI Development , Ben Widawsky List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKYW4gMjIsIDIwMTQgYXQgMTE6MTE6MTBBTSArMDEwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAyMS4wMS4yMDE0IDIxOjMzLCBzY2hyaWViIEJlbiBXaWRhd3NreToKPiA+ VGhlIGRlYnVnZnMgaGVscGVyIGR1cGxpY2F0ZXMgdGhlIGZ1bmN0aW9uYWxpdHkgdXNlZCBieSBB cm1hZGEsIHNvIGxldCdzCj4gPmp1c3QgdXNlIHRoYXQuCj4gPgo+ID5XQVJOSU5HOiBvbmx5IGNv bXBpbGUgdGVzdGVkCj4gPgo+ID5DYzogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5p Z0BhbWQuY29tPgo+ID5TaWduZWQtb2ZmLWJ5OiBCZW4gV2lkYXdza3kgPGJlbkBid2lkYXdzay5u ZXQ+Cj4gPi0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uLmggICAgIHwgIDUg LS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl90dG0uYyB8IDQzICsrKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDI2 IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+ID4KPiA+ZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uLmggYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVv bi5oCj4gPmluZGV4IGM1NTE5Y2EuLmNlZWM0NjggMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9yYWRlb24vcmFkZW9uLmgKPiA+KysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRl b24uaAo+ID5AQCAtNDE4LDExICs0MTgsNiBAQCBzdHJ1Y3QgcmFkZW9uX21tYW4gewo+ID4gIAlz dHJ1Y3QgdHRtX2JvX2RldmljZQkJYmRldjsKPiA+ICAJYm9vbAkJCQltZW1fZ2xvYmFsX3JlZmVy ZW5jZWQ7Cj4gPiAgCWJvb2wJCQkJaW5pdGlhbGl6ZWQ7Cj4gPi0KPiA+LSNpZiBkZWZpbmVkKENP TkZJR19ERUJVR19GUykKPiA+LQlzdHJ1Y3QgZGVudHJ5CQkJKnZyYW07Cj4gPi0Jc3RydWN0IGRl bnRyeQkJCSpndHQ7Cj4gPi0jZW5kaWYKPiA+ICB9Owo+ID4gIC8qIGJvIHZpcnR1YWwgYWRkcmVz cyBpbiBhIHNwZWNpZmljIHZtICovCj4gPmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFk ZW9uL3JhZGVvbl90dG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX3R0bS5jCj4g PmluZGV4IDc3ZjViMGMuLmNmN2NhZjIgMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9y YWRlb24vcmFkZW9uX3R0bS5jCj4gPisrKyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u X3R0bS5jCj4gPkBAIC05NzEsMjcgKzk3MSwzNCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGZpbGVf b3BlcmF0aW9ucyByYWRlb25fdHRtX2d0dF9mb3BzID0gewo+ID4gIAkubGxzZWVrID0gZGVmYXVs dF9sbHNlZWsKPiA+ICB9Owo+ID4rc3RhdGljIGNvbnN0IHN0cnVjdCByYWRlb25fZGVidWdmc19m aWxlcyB7Cj4gPisJY29uc3QgY2hhciAqbmFtZTsKPiA+Kwljb25zdCBzdHJ1Y3QgZmlsZV9vcGVy YXRpb25zICpmb3BzOwo+ID4rfSByYWRlb25fZGVidWdmc19maWxlc1tdID0gewo+ID4rCXsicmFk ZW9uX3ZyYW0iLCAmcmFkZW9uX3R0bV92cmFtX2ZvcHN9LAo+ID4rCXsicmFkZW9uX2d0dCIsICZy YWRlb25fdHRtX2d0dF9mb3BzfSwKPiA+K307Cj4gPiAgI2VuZGlmCj4gPiAgc3RhdGljIGludCBy YWRlb25fdHRtX2RlYnVnZnNfaW5pdChzdHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldikKPiA+ICB7 Cj4gPiAgI2lmIGRlZmluZWQoQ09ORklHX0RFQlVHX0ZTKQo+ID4gIAl1bnNpZ25lZCBjb3VudDsK PiA+KwlpbnQgaSwgcmV0Owo+ID4gIAlzdHJ1Y3QgZHJtX21pbm9yICptaW5vciA9IHJkZXYtPmRk ZXYtPnByaW1hcnk7Cj4gPi0Jc3RydWN0IGRlbnRyeSAqZW50LCAqcm9vdCA9IG1pbm9yLT5kZWJ1 Z2ZzX3Jvb3Q7Cj4gPi0KPiA+LQllbnQgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJyYWRlb25fdnJh bSIsIFNfSUZSRUcgfCBTX0lSVUdPLCByb290LAo+ID4tCQkJCSAgcmRldiwgJnJhZGVvbl90dG1f dnJhbV9mb3BzKTsKPiA+LQlpZiAoSVNfRVJSKGVudCkpCj4gPi0JCXJldHVybiBQVFJfRVJSKGVu dCk7Cj4gPi0JcmRldi0+bW1hbi52cmFtID0gZW50Owo+ID4tCj4gPi0JZW50ID0gZGVidWdmc19j cmVhdGVfZmlsZSgicmFkZW9uX2d0dCIsIFNfSUZSRUcgfCBTX0lSVUdPLCByb290LAo+ID4tCQkJ CSAgcmRldiwgJnJhZGVvbl90dG1fZ3R0X2ZvcHMpOwo+ID4tCWlmIChJU19FUlIoZW50KSkKPiA+ LQkJcmV0dXJuIFBUUl9FUlIoZW50KTsKPiA+LQlyZGV2LT5tbWFuLmd0dCA9IGVudDsKPiA+Kwlz dHJ1Y3QgZGVudHJ5ICpyb290ID0gbWlub3ItPmRlYnVnZnNfcm9vdDsKPiA+Kwo+ID4rCWZvciAo aSA9IDA7IGkgPCBBUlJBWV9TSVpFKHJhZGVvbl9kZWJ1Z2ZzX2ZpbGVzKTsgaSsrKSB7Cj4gPisJ CXJldCA9IGRybV9kZWJ1Z2ZzX2NyZWF0ZV9maWxlKHJvb3QsIG1pbm9yLAo+ID4rCQkJCQkgICAg ICByYWRlb25fZGVidWdmc19maWxlc1tpXS5uYW1lLAo+ID4rCQkJCQkgICAgICByYWRlb25fZGVi dWdmc19maWxlc1tpXS5mb3BzLAo+ID4rCQkJCQkgICAgICBTX0lGUkVHIHwgU19JV1VTUik7Cj4g PisJCWlmIChyZXQpIHsKPiA+KwkJCXJhZGVvbl90dG1fZGVidWdmc19maW5pKHJkZXYpOwo+ID4r CQkJcmV0dXJuIHJldDsKPiA+KwkJfQo+ID4rCX0KPiA+ICAJY291bnQgPSBBUlJBWV9TSVpFKHJh ZGVvbl90dG1fZGVidWdmc19saXN0KTsKPiA+QEAgLTEwMTAsMTEgKzEwMTcsMTMgQEAgc3RhdGlj IGludCByYWRlb25fdHRtX2RlYnVnZnNfaW5pdChzdHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldikK PiA+ICBzdGF0aWMgdm9pZCByYWRlb25fdHRtX2RlYnVnZnNfZmluaShzdHJ1Y3QgcmFkZW9uX2Rl dmljZSAqcmRldikKPiA+ICB7Cj4gPiAgI2lmIGRlZmluZWQoQ09ORklHX0RFQlVHX0ZTKQo+ID4r CWludCBpOwo+ID4tCWRlYnVnZnNfcmVtb3ZlKHJkZXYtPm1tYW4udnJhbSk7Cj4gPi0JcmRldi0+ bW1hbi52cmFtID0gTlVMTDsKPiA+Kwlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShyYWRlb25f ZGVidWdmc19maWxlcyk7IGkrKykgewo+ID4rCQlzdHJ1Y3QgZHJtX2luZm9fbGlzdCAqaW5mb19s aXN0ID0KPiA+KwkJCShzdHJ1Y3QgZHJtX2luZm9fbGlzdCAqKSZyYWRlb25fZGVidWdmc19maWxl c1tpXTsKPiA+LQlkZWJ1Z2ZzX3JlbW92ZShyZGV2LT5tbWFuLmd0dCk7Cj4gPi0JcmRldi0+bW1h bi5ndHQgPSBOVUxMOwo+ID4rCQlkcm1fZGVidWdmc19yZW1vdmVfZmlsZXMoaW5mb19saXN0LCAx LCByZGV2LT5kZGV2LT5wcmltYXJ5KTsKPiAKPiBUaGlzIHdvbid0IHdvcmsgY29ycmVjdGx5IGJl Y2F1c2UgaW5mb19lbnQgZG9lc24ndCBjb250YWluIHRoaXMgcG9pbnRlciBidXQKPiBhIHBvaW50 ZXIgdG8gdGhlIGZvcHMgaW5zdGVhZC4KCllvdSBhcmUgY29ycmVjdC4gSXQgc2hvdWxkIGhhdmUg YmVlbiAmcmFkZW9uX2RlYnVnZnNfZmlsZXNbaV0uZm9wcy4KCj4gQWRkaXRpb25hbCB0byB0aGF0 IHRoZSBmb3BzIG1pZ2h0IG5vdCBiZSB1bmlxdWUgKHlvdSBjYW4gdXNlIHRoZSBzYW1lCj4gZm9w cyBmb3IgZGlmZmVyZW50IGZpbGVzKSBzbyB0aGV5IGFyZSBwcm9iYWJseSBub3Qgc3VjaCBhIGdv b2QgY2hvaWNlCj4gYXMgdGhlIGtleS4KClRoaXMgaXMgY29ycmVjdCwgYW5kIEkgZWxhYm9yYXRl IGEgYml0IG9uIHRoaXMgaW4gYSBsYXRlciBwYXRjaCAob3IKZWFybGllciwgSSBmb3JnZXQpLiBF c3NlbnRpYWxseSB3ZSBoYXZlIGV4YWN0bHkgb25lIHVzYWdlIChhZmFpY3QpIG9mIGEKY2FsbGVy IHRoYXQgd2FudHMgYSBmb3BzICE9IGtleS4gSSBkaWRuJ3Qgd2FudCB0byBjcmVhdGUgdGhlIGlu dGVyZmFjZQphcm91bmQgdGhpcyBwb3NzaWJpbGl0eSwgYnV0IHJhdGhlciBsZXQgb3RoZXIgZXh0 ZW5kIGl0IHdoZW4gaXQgYmVjb21lcwptb3JlIGNvbW1vbi4KCkhvd2V2ZXIsIGlmIHRoaXMgaXMg cmVxdWVzdGVkL3JlcXVpcmVkLCB3aGF0IEkgd291bGQgZG8gaXMgcHJvdmlkZSBhCnZvaWQgKmtl eSBhcmd1bWVudCwgd2hlcmUgYSBOVUxMIHZhbHVlIHdpbGwgcmVzdWx0IGluIHVzaW5nIGZvcHMu CgoKPiAKPiBPbiB0aGUgb3RoZXIgaGFuZCB3aHkgZG8gdGhlIGRybSBsYXllciB3YW50IHRvIGRv IHRoaXMgYm9va2tlZXBpbmcgb2YKPiBhbGwgdGhlIGNyZWF0ZWQgZmlsZXMgaW4gdGhlIGZpcnN0 IHBsYWNlPyBXZSBjb3VsZCBqdXN0IHVzZQo+IGRlYnVnZnNfcmVtb3ZlX3JlY3Vyc2l2ZSBpbnN0 ZWFkIGFuZCBkb24ndCBuZWVkIHRvIG1lc3Mgd2l0aCB0aGlzIGF0Cj4gYWxsLgo+IAo+IFJlZ2Fy ZHMsIENocmlzdGlhbi4KPiAKClRoZSBhbnN3ZXIgdG8gdGhlIHF1ZXN0aW9uIHByZWRhdGVzIG1l LiBJIHRoaW5rIGhhdmluZyB0aGUgaGVscGVycyBmb3IKdGhlIGNvbW1vbiBjYXNlLCB3aGVyZSB5 b3Ugb25seSB3YW50IGEgc2hvdygpIGZ1bmN0aW9uIGlzIGhhbmR5LiBUaGUKZGVjaXNpb24gdG8g c3BsaXQgb2ZmIGFuZCBjb250aW51ZSB0byBzaG9laG9ybiBuZXdlciwgbW9yZSBmZWF0dXJlZApk ZWJ1Z2ZzIGZpbGVzIChhcyB5b3UgaGF2ZSBkb25lIGluIFJhZGVvbiB3aXRoIHRoZXNlIHR3bywg YW5kIGFzIHdlIGhhdmUKZG9uZSBpbiBpOTE1IGFsbCBvdmVyKSB3YXMgbm90IG9uZSBJIG1hZGUs IG5vciBvbmUgSSByZWFsbHkgY2FyZSB0byBmaXguCgpTbyBhc3N1bWluZyBJIGZpeCB0aGUgYnVn LCB3aGF0IGRvIHlvdSB3YW50IHRvIG1lIGRvPwoKPiA+Kwl9ICNlbmRpZiB9Cj4gCj4gCgotLSAK QmVuIFdpZGF3c2t5LCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=