From: Peter Zijlstra <peterz@infradead.org>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, fweisbec@gmail.com,
mingo@redhat.com
Subject: Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.
Date: Thu, 23 Jan 2014 09:26:30 +0100 [thread overview]
Message-ID: <20140123082630.GO30183@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <52E14D28.2090208@cn.fujitsu.com>
On Thu, Jan 23, 2014 at 12:11:04PM -0500, Dongsheng Yang wrote:
> On 01/22/2014 11:00 PM, Steven Rostedt wrote:
> >
> >Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not
> >include/linux/sched.h
> >
> >Peter, is there a reason that task_nice() is not a static inline in
> >sched.h and have these macros there too? They only reference fields in
> >task_struct that are already defined there. I don't see why they need
> >to be private to kernel/sched.
>
> Agree. These macros are useful to other modules out of kernel/sched.
> But they are private to kernel/sched currently.
And the floodgates open.. _why_ would a module care about nice values?
That's sounds just so full of wrong.
next prev parent reply other threads:[~2014-01-23 8:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 22:41 [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task Dongsheng Yang
2014-01-23 3:56 ` Steven Rostedt
2014-01-23 4:00 ` Steven Rostedt
2014-01-23 17:11 ` Dongsheng Yang
2014-01-23 8:26 ` Peter Zijlstra [this message]
2014-01-23 11:52 ` Steven Rostedt
2014-01-27 22:15 ` [PATCH 0/3] sched: Collect the bits about priority into a new header file, include/linux/sched/prio.h Dongsheng Yang
2014-01-27 15:45 ` Steven Rostedt
[not found] ` <CA+qeAOqW58894hGvCP0N0E-EUESfFPeqMmXUuhqxEZrRjDV97A@mail.gmail.com>
2014-01-28 16:06 ` Steven Rostedt
2014-01-27 22:15 ` [PATCH 1/3] sched: Move the priority specific bits into a new header file Dongsheng Yang
2014-01-29 5:28 ` Namhyung Kim
2014-02-10 2:56 ` Dongsheng Yang
2014-02-10 14:09 ` Steven Rostedt
2014-02-11 1:10 ` Dongsheng Yang
2014-02-10 13:30 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-01-27 22:15 ` [PATCH 2/3] sched: Expose some macros related with priority Dongsheng Yang
2014-02-10 13:30 ` [tip:sched/core] sched: Expose some macros related to priority tip-bot for Dongsheng Yang
2014-01-27 22:15 ` [PATCH 3/3] sched: Implement task_nice and task_prio as static inline functions Dongsheng Yang
2014-01-27 10:32 ` Peter Zijlstra
2014-01-28 1:09 ` Dongsheng Yang
2014-01-27 12:16 ` Peter Zijlstra
2014-01-28 1:59 ` Dongsheng Yang
2014-01-27 13:08 ` Peter Zijlstra
2014-01-28 3:00 ` [PATCH 3/3 V2] sched: Implement task_nice as static inline function Dongsheng Yang
2014-01-28 3:27 ` Dongsheng Yang
2014-02-10 13:32 ` [tip:sched/core] sched: Implement task_nice() " tip-bot for Dongsheng Yang
2014-01-23 21:43 ` [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task Dongsheng Yang
2014-02-11 3:19 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123082630.GO30183@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.