From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH V4] drm/i915: VLV2 - Fix hotplug detect bits
Date: Thu, 23 Jan 2014 11:52:51 +0100
Message-ID: <20140123105251.GT9772@phenom.ffwll.local>
References: <1390322330-6486-1-git-send-email-tprevite@gmail.com>
	<1390461221-19715-1-git-send-email-tprevite@gmail.com>
	<1390461221-19715-2-git-send-email-tprevite@gmail.com>
	<20140123105038.GS9772@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com
	[209.85.215.173])
	by gabe.freedesktop.org (Postfix) with ESMTP id 95687FBEAD
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 23 Jan 2014 02:52:57 -0800 (PST)
Received: by mail-ea0-f173.google.com with SMTP id d10so333467eaj.18
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 23 Jan 2014 02:52:55 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140123105038.GS9772@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Todd Previte <tprevite@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jan 23, 2014 at 11:50:38AM +0100, Daniel Vetter wrote:
> On Thu, Jan 23, 2014 at 12:13:41AM -0700, Todd Previte wrote:
> > Add new definitions for hotplug live status bits for VLV2 since they're
> > in reverse order from the gen4x ones.
> > 
> > Changelog:
> > - Restored gen4 bit definitions
> > - Added new definitions for VLV2
> > - Added platform check for IS_VALLEYVIEW() in dp_detect to use the correct
> >   bit defintions
> > - Replaced a lost trailing brace for the added switch()
> > 
> > Signed-off-by: Todd Previte <tprevite@gmail.com>
> 
> I've bikeshedded your patch a bit for more consistency. Wrt the patch
> changelog please don't smash it all into one but keep a separate changelog
> per revision. Otherwise it's not clear what e.g. changed from v3->v4 and
> so no too useful for reviewers when rechecking patches.

Also please add bugzilla links and cc: stable for bugfixes like these into
the sob section of the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch