From: Thierry Reding <thierry.reding@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-pwm@vger.kernel.org
Subject: Re: [PATCH Resend 1/2] pwm: atmel: Remove redundant of_match_ptr helper
Date: Thu, 23 Jan 2014 13:44:06 +0100 [thread overview]
Message-ID: <20140123124405.GA28527@ulmo.nvidia.com> (raw)
In-Reply-To: <1390474715-6587-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
On Thu, Jan 23, 2014 at 04:28:34PM +0530, Sachin Kamat wrote:
> 'atmel_pwm_dt_ids' is always compiled in. Hence the
> helper macro is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/pwm/pwm-atmel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Sachin,
Sorry for taking so long to look at this, things have been pretty
busy...
> diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
> index bf4144a14661..45f0fb793528 100644
> --- a/drivers/pwm/pwm-atmel.c
> +++ b/drivers/pwm/pwm-atmel.c
> @@ -381,7 +381,7 @@ static int atmel_pwm_remove(struct platform_device *pdev)
> static struct platform_driver atmel_pwm_driver = {
> .driver = {
> .name = "atmel-pwm",
> - .of_match_table = of_match_ptr(atmel_pwm_dt_ids),
> + .of_match_table = atmel_pwm_dt_ids,
> },
> .id_table = atmel_pwm_devtypes,
> .probe = atmel_pwm_probe,
Given that the driver doesn't depend on OF, I think the right thing to
do here would be to #ifdef the atmel_pwm_dt_ids so it doesn't waste
needless memory.
See also my comment to patch 2/2 that I'm about to send out.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-23 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 10:58 [PATCH Resend 1/2] pwm: atmel: Remove redundant of_match_ptr helper Sachin Kamat
2014-01-23 10:58 ` [PATCH Resend 2/2] pwm: pxa: Use " Sachin Kamat
2014-01-23 12:48 ` Thierry Reding
2014-01-24 9:05 ` Sachin Kamat
2014-01-23 12:44 ` Thierry Reding [this message]
2014-01-24 9:04 ` [PATCH Resend 1/2] pwm: atmel: Remove redundant " Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123124405.GA28527@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=linux-pwm@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.