From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tom Herbert <therbert@google.com>
Cc: Zhi Yong Wu <zwu.kernel@gmail.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Jason Wang <jasowang@redhat.com>
Subject: Re: Fwd: [RFC PATCH net-next 0/3] virtio_net: add aRFS support
Date: Thu, 23 Jan 2014 16:23:57 +0200 [thread overview]
Message-ID: <20140123142357.GC21572@redhat.com> (raw)
In-Reply-To: <CA+mtBx-Xv6xp3VCq=PKMyboAmDjUWzVrbUhr4WdKQRi1PCansg@mail.gmail.com>
On Wed, Jan 22, 2014 at 10:00:37AM -0800, Tom Herbert wrote:
> >> 1. The aRFS interface for the guest to specify which virtual queue to
> >> receive a packet on is fairly straight forward.
> >> 2. To hook into RFS, we need to match the virtual queue to the real
> >> CPU it will processed on, and then program the RFS table for that flow
> >> and CPU.
> >> 3. NIC aRFS keys off the RFS tables so it can program the HW with the
> >> correct queue for the CPU.
> > Does anyone have time to make one conclusion for this discussion? in
> > particular, how will rx packet be steered up the stack from guest
> > virtio_net driver, virtio_net NIC, vhost_net, tun driver, host network
> > stack, to physical NIC with more details?
> > What is the role of each path units? otherwise this discussion wont
> > get any meanful result, which is not what we expect.
> >
> Working code outweighs theoretical discussion :-).
So far all that was posted was an untested patchset.
Zhi Yong Wu did this intentionally to get early feedback, so
it's not surprising we got a theoretical discussion
as opposed to working code out of this.
> I think you started
> on a good track with original patches, and I believe the tun path
> should work pretty well (some performance numbers would still be good
> to validate).
Yes, merging performance-oriented patches without any
performance numbers to show for it is strange.
> Seems like there's enough hooks in the virtio_net path
> to implement something meaningful and maybe get some numbers (maybe
> ignore NIC aRFS in the first pass).
>
> Tom
>
> >>
> >>> Stefan
> >
> >
> >
> > --
> > Regards,
> >
> > Zhi Yong Wu
next prev parent reply other threads:[~2014-01-23 14:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 14:20 [RFC PATCH net-next 0/3] virtio_net: add aRFS support Zhi Yong Wu
2014-01-15 14:20 ` [RFC PATCH net-next 1/3] virtio_pci: Introduce one new config api vp_get_vq_irq() Zhi Yong Wu
2014-01-15 14:20 ` [RFC PATCH net-next 2/3] virtio_net: Introduce one dummy function virtnet_filter_rfs() Zhi Yong Wu
2014-01-15 17:54 ` Tom Herbert
2014-01-16 2:45 ` Zhi Yong Wu
2014-01-15 14:20 ` [RFC PATCH net-next 3/3] virtio-net: Add accelerated RFS support Zhi Yong Wu
2014-01-16 21:31 ` Ben Hutchings
2014-01-16 22:00 ` Zhi Yong Wu
2014-01-16 23:16 ` Ben Hutchings
2014-01-17 16:54 ` Zhi Yong Wu
2014-01-17 17:20 ` Ben Hutchings
2014-01-18 4:59 ` Tom Herbert
2014-01-18 14:19 ` Ben Hutchings
2014-01-16 4:23 ` [RFC PATCH net-next 0/3] virtio_net: add aRFS support Jason Wang
2014-01-16 8:34 ` Fwd: " Zhi Yong Wu
2014-01-16 8:52 ` Stefan Hajnoczi
2014-01-16 17:12 ` Tom Herbert
2014-01-17 3:26 ` Jason Wang
2014-01-17 5:08 ` Tom Herbert
2014-01-17 6:36 ` Jason Wang
2014-01-17 16:03 ` Tom Herbert
2014-01-17 5:22 ` Stefan Hajnoczi
2014-01-17 6:45 ` Jason Wang
2014-01-20 14:36 ` Ben Hutchings
2014-01-22 13:27 ` Zhi Yong Wu
2014-01-22 18:00 ` Tom Herbert
2014-01-23 0:40 ` Zhi Yong Wu
2014-01-23 14:23 ` Michael S. Tsirkin [this message]
2014-01-17 3:04 ` Jason Wang
2014-01-20 16:49 ` Stefan Hajnoczi
2014-01-16 8:48 ` Zhi Yong Wu
2014-01-23 14:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123142357.GC21572@redhat.com \
--to=mst@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@redhat.com \
--cc=therbert@google.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.