From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bjorn Helgaas <bhelgaas@google.com>, Dave Jones <davej@redhat.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [scan-admin@coverity.com: New Defects reported by Coverity Scan for Linux]
Date: Thu, 23 Jan 2014 11:34:05 -0800 [thread overview]
Message-ID: <20140123193405.GB2605@kroah.com> (raw)
In-Reply-To: <20140123184246.GA7461@google.com>
On Thu, Jan 23, 2014 at 11:42:46AM -0700, Bjorn Helgaas wrote:
> FYI. I think the first two (related to "name") are valid. I haven't
> figured out the "msi_attrs" one yet.
I've send a fix for the first two to you now, that should resolve this
issue.
But the last one, I can't figure out either. I think Coverity doesn't
realize that we saved off the pointer and can get back to it later on,
as it's a non-trivial pointer chain involved here.
Dave, you stare at Coverity bug reports all the time, can you make any
sense out of the following report:
> Please find the latest report on new defect(s) introduced to Linux found with Coverity Scan.
>
> ...
>
>
> ** CID 1163317: Resource leak (RESOURCE_LEAK)
> /drivers/pci/msi.c: 592 in populate_msi_sysfs()
>
> ...
> ________________________________________________________________________________________________________
> *** CID 1163317: Resource leak (RESOURCE_LEAK)
> /drivers/pci/msi.c: 592 in populate_msi_sysfs()
> 586 msi_dev_attr = container_of(msi_attr, struct device_attribute, attr);
> 587 kfree(msi_attr->name);
> 588 kfree(msi_dev_attr);
> 589 ++count;
> 590 msi_attr = msi_attrs[count];
> 591 }
> >>> CID 1163317: Resource leak (RESOURCE_LEAK)
> >>> Variable "msi_attrs" going out of scope leaks the storage it points to.
> 592 return ret;
> 593 }
> 594
> 595 /**
> 596 * msi_capability_init - configure device's MSI capability structure
> 597 * @dev: pointer to the pci_dev data structure of MSI device function
>
> ...
>
> To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/128?tab=Overview
>
> ----- End forwarded message -----
next prev parent reply other threads:[~2014-01-23 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 18:42 [scan-admin@coverity.com: New Defects reported by Coverity Scan for Linux] Bjorn Helgaas
2014-01-23 19:15 ` Greg Kroah-Hartman
2014-01-23 19:30 ` [PATCH] PCI: msi: properly check return value of kmalloc Greg Kroah-Hartman
2014-01-23 20:01 ` [PATCH] PCI: msi: properly free memory on an error path Greg Kroah-Hartman
2014-01-23 20:07 ` Dave Jones
2014-01-29 20:56 ` Bjorn Helgaas
2014-01-29 20:56 ` [PATCH] PCI: msi: properly check return value of kmalloc Bjorn Helgaas
2014-01-23 19:34 ` Greg Kroah-Hartman [this message]
2014-01-23 19:46 ` [scan-admin@coverity.com: New Defects reported by Coverity Scan for Linux] Dave Jones
2014-01-23 19:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123193405.GB2605@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=davej@redhat.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.