All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Valentina Manea <valentina.manea.m@gmail.com>
Cc: Anthony Foiani <anthony.foiani@gmail.com>,
	devel@driverdev.osuosl.org, navinp@cdac.in,
	linux-usb@vger.kernel.org, ly80toro@cip.cs.fau.de,
	josh@joshtriplett.org, linux-kernel@vger.kernel.org,
	"Linux Kernel Community @ ROSEdu" <firefly@lists.rosedu.org>,
	tulinizer@gmail.com, stern@rowland.harvard.edu,
	yacine.belkadi.1@gmail.com, ke42caxa@cip.cs.fau.de
Subject: Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver
Date: Thu, 23 Jan 2014 11:45:10 -0800	[thread overview]
Message-ID: <20140123194510.GA10745@kroah.com> (raw)
In-Reply-To: <CABdoFFeC=S6raty6d6+4sfm4zk7jiF-XnBKgxzTmEzmf6wX3CA@mail.gmail.com>

On Thu, Jan 23, 2014 at 09:37:28PM +0200, Valentina Manea wrote:
> On Thu, Jan 23, 2014 at 9:09 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Jan 23, 2014 at 08:36:46PM +0200, Valentina Manea wrote:
> >> This driver was previously an interface driver. Since USB/IP
> >> exports a whole device, not just an interface, it would make
> >> sense to be a device driver.
> >>
> >> This patch also modifies the way userspace sees and uses a
> >> shared device - dealing with interfaces is no longer required.
> >
> > In what way is this modified?  What is now different?
> >
> 
> 1. The usbip_status file is no longer created for interface 0, but for
> the whole device (such as
> /sys/devices/pci0000:00/0000:00:01.2/usb1/1-1/usbip_status).
> 2. Per interface information, such as interface class or protocol, is
> no longer sent/received. Only device specific information is
> transmitted.
> 3. Since the driver was moved one level below in the USB architecture,
> there is no need to bind/unbind each interface, just the device as a
> whole.

Please say all of this in your changelog entry :)

thanks,

greg k-h

  reply	other threads:[~2014-01-23 19:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 18:36 [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver Valentina Manea
2014-01-23 19:09 ` Greg KH
2014-01-23 19:37   ` Valentina Manea
2014-01-23 19:45     ` Greg KH [this message]
2014-01-23 20:06     ` Alan Stern
2014-01-23 21:10       ` Valentina Manea
2014-01-23 19:58 ` [PATCH v2] " Valentina Manea
2014-01-23 21:12 ` [PATCH v3] " Valentina Manea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140123194510.GA10745@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=anthony.foiani@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=firefly@lists.rosedu.org \
    --cc=josh@joshtriplett.org \
    --cc=ke42caxa@cip.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ly80toro@cip.cs.fau.de \
    --cc=navinp@cdac.in \
    --cc=stern@rowland.harvard.edu \
    --cc=tulinizer@gmail.com \
    --cc=valentina.manea.m@gmail.com \
    --cc=yacine.belkadi.1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.