Re: [PATCH RFC 4/4] spi: dw: migrate to generic queue infrastructure

[Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>]

Hi Mark,

On Thu, Jan 23, 2014 at 08:13:06PM +0000, Mark Brown wrote:
> On Thu, Jan 23, 2014 at 10:07:10PM +0200, Baruch Siach wrote:
> > I'll look into it. I had to dig in include/linux/spi/spi.h, 'git blame' 
> > and commit b158935f70b9c to see how it all works together. The 
> > Documentation/spi/spi-summary doesn't mention the transfer_one callback. 
> > The kerneldoc in spi.h should make it clear that transfer_one and 
> > transfer_one_message are mutually exclusive.
> 
> Feel free to submit documentation patches...

Done.

> I'd have thought that transfer_one_message() and transfer_one() being 
> exclusive was fairly obvious given that the former takes an entire message.

IMO, adding this small clarification would better serve newcomers. I think 
there is also a need for some additional explanation on the difference between 
these two callback, and why a driver should implement one over the other. I 
hope to look into it when I have more experience with the new API.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html