From: Al Viro <viro@ZenIV.linux.org.uk>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dcache: fix locking bug in __dentry_path()
Date: Fri, 24 Jan 2014 12:24:09 +0000 [thread overview]
Message-ID: <20140124122409.GT10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1390558886-4152-1-git-send-email-dvlasenk@redhat.com>
On Fri, Jan 24, 2014 at 11:21:26AM +0100, Denys Vlasenko wrote:
> If given buffer size is zero, we forget to rcu_read_unlock()
> on error path.
Er... Where could we ever get called with size zero? IOW, the
real question is whether that check makes any sense. If nothing
else, a much more obvious fix (again, assuming there is a call
chain that could have triggered that in the first place), would
be to take that
if (buflen < 1)
goto Elong;
on the very top of __dentry_path(). Note that buflen never
change, so this check could bloody well be handled once - and
earlier. But again, the callers shouldn't be calling it that
way...
next prev parent reply other threads:[~2014-01-24 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 10:21 [PATCH] dcache: fix locking bug in __dentry_path() Denys Vlasenko
2014-01-24 12:24 ` Al Viro [this message]
2014-01-24 13:42 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124122409.GT10323@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.