From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6jdH-0005tL-V8 for qemu-devel@nongnu.org; Fri, 24 Jan 2014 11:29:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6jdC-0006oG-VM for qemu-devel@nongnu.org; Fri, 24 Jan 2014 11:29:27 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:48266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6jdC-0006oC-Ld for qemu-devel@nongnu.org; Fri, 24 Jan 2014 11:29:22 -0500 Date: Fri, 24 Jan 2014 17:29:20 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140124162920.GE3087@irqsave.net> References: <1389968119-24771-1-git-send-email-kwolf@redhat.com> <1389968119-24771-26-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1389968119-24771-26-git-send-email-kwolf@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 25/29] iscsi: Set bs->request_alignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com Le Friday 17 Jan 2014 =E0 15:15:15 (+0100), Kevin Wolf a =E9crit : > From: Paolo Bonzini >=20 > The iSCSI backend already gets the block size from the READ CAPACITY > command it sends. Save it so that the generic block layer gets it > too. >=20 > Signed-off-by: Paolo Bonzini > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > block/iscsi.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/block/iscsi.c b/block/iscsi.c > index 3202dc5..23c3fc4 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -1217,6 +1217,7 @@ static int iscsi_open(BlockDriverState *bs, QDict= *options, int flags, > goto out; > } > bs->total_sectors =3D sector_lun2qemu(iscsilun->num_blocks, iscsil= un); > + bs->request_alignment =3D iscsilun->block_size; > =20 > /* Medium changer or tape. We dont have any emulation for this so = this must > * be sg ioctl compatible. We force it to be sg, otherwise qemu wi= ll try > --=20 > 1.8.1.4 >=20 >=20 Reviewed-by: Benoit Canet