Re: [PATCH] ASoC: arizona: Check clocking during hw_params rather than startup

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1301 bytes --]

On Fri, Jan 24, 2014 at 06:25:06PM +0100, Lars-Peter Clausen wrote:

> The problem with this approach is that if the sysclk is fixed instead to
> e.g. falling back to rate conversion you'll get an error instead when
> calling hw_params. The typical idiom here is to only apply the rate
> constraints in the CODEC driver if the sysclk is non zero. This driver
> already seems to do this. The problem that you probably see is that if the
> machine driver changes the sysclk value in hw_params the constraints that

Thanks, that's about what I was going to write.  The current theory is
that setting the sysclk to zero is the equivalent of a dynamic SYSCLK
flag - with the extensive use of charge pumps and so on in modern
devices on the fly reclocking is normally difficult to do safely so the
idea is that if the machine driver is in a position to reclock it should
set the clock to zero.

> are setup are still setup with the previous sysclk in mind. I think instead
> of removing the constraints support altogether from the driver a better
> solution is to introduce a dynamic_sysclk or similar attribute to the DAI
> link and not constrain the supported rates if this attribute is set to true.

It would be useful to have this more in the core rather than open coded,
as with the sample size stuff.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]