From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] minios: Correct HYPERVISOR_physdev_op()
Date: Fri, 24 Jan 2014 13:44:06 -0500
Message-ID: <20140124184406.GB16410@phenom.dumpdata.com>
References: <1390588091-17670-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1390588091-17670-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jan 24, 2014 at 06:28:11PM +0000, Andrew Cooper wrote:
> A physdev_op is a two argument hypercall, taking a command paramter and an
                                                             ^^^^^^^- parameter
> optional pointer to a structure.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> CC: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
>  extras/mini-os/include/x86/x86_32/hypercall-x86_32.h |    4 ++--
>  extras/mini-os/include/x86/x86_64/hypercall-x86_64.h |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h b/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
> index ef52ecd..dcfbe41 100644
> --- a/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
> +++ b/extras/mini-os/include/x86/x86_32/hypercall-x86_32.h
> @@ -255,9 +255,9 @@ HYPERVISOR_console_io(
>  
>  static inline int
>  HYPERVISOR_physdev_op(
> -	void *physdev_op)
> +	int cmd, void *physdev_op)
>  {
> -	return _hypercall1(int, physdev_op, physdev_op);
> +	return _hypercall2(int, physdev_op, cmd, physdev_op);
>  }
>  
>  static inline int
> diff --git a/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h b/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
> index 513d74e..7083763 100644
> --- a/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
> +++ b/extras/mini-os/include/x86/x86_64/hypercall-x86_64.h
> @@ -256,9 +256,9 @@ HYPERVISOR_console_io(
>  
>  static inline int
>  HYPERVISOR_physdev_op(
> -	void *physdev_op)
> +	int cmd, void *physdev_op)
>  {
> -	return _hypercall1(int, physdev_op, physdev_op);
> +	return _hypercall2(int, physdev_op, cmd, physdev_op);
>  }
>  
>  static inline int
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel