From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from merlin.infradead.org ([205.233.59.134]:49109 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbaAXUHe (ORCPT ); Fri, 24 Jan 2014 15:07:34 -0500 Date: Fri, 24 Jan 2014 12:07:32 -0800 From: Jens Axboe Subject: Re: [PATCH] Adds check for numberio during verify phase. Message-ID: <20140124200732.GI7483@kernel.dk> References: <1379451974-16100-1-git-send-email-jcasse@chromium.org> <20140124185855.GF7483@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: fio-owner@vger.kernel.org List-Id: fio@vger.kernel.org To: Grant Grundler Cc: FIO_list On Fri, Jan 24 2014, Grant Grundler wrote: > [dropping jcasse since this account was deleted after his internship ended] > > On Fri, Jan 24, 2014 at 10:58 AM, Jens Axboe wrote: > > On Fri, Jan 24 2014, Grant Grundler wrote: > >> Jens, Ping? > >> You think you can still integrate the three patches from Juan? > > > > I think that would be manageable. But really a new feature (or feature > > modification) like this should be accompanies by a job file example for > > it. Care to provide one? > > Yes. Do you mind cloning a git repo? It was big :-) > Specifically this file is what chromium.org is using: > https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/client/site_tests/hardware_StorageFio/8k_async_randwrite > > The git repo is hosted here: > https://chromium.googlesource.com/chromiumos/third_party/autotest/ > > Use git clone to pull the entire repo: > git clone https://chromium.googlesource.com/chromiumos/third_party/autotest > > > BTW, Verification is failing on the 1m_stress control file...working > on that now: > https://code.google.com/p/chromium/issues/detail?id=337651 > > I suspect it's a problem of the control file though since we are > getting this warning: > "Multiple writers may overwrite blocks that belong to other jobs. > This can cause verification failures." Yes, with 8 jobs going, they are going to be stomping on each others blocks potentially. I queued up the 3 patches, but I killed the --verify-only command line switch. Seems unneeded, might as well just use the job option for that. -- Jens Axboe