From: Jens Axboe <axboe@kernel.dk>
To: Grant Grundler <grundler@chromium.org>
Cc: FIO_list <fio@vger.kernel.org>
Subject: Re: [PATCH] Adds check for numberio during verify phase.
Date: Fri, 24 Jan 2014 15:17:05 -0800 [thread overview]
Message-ID: <20140124231705.GG9593@kernel.dk> (raw)
In-Reply-To: <CANEJEGvKyMMRSoxiJZAHPkGsf-SF8oEhmW6atoaBG-FVozSEtQ@mail.gmail.com>
On Fri, Jan 24 2014, Grant Grundler wrote:
> On Fri, Jan 24, 2014 at 1:19 PM, Jens Axboe <axboe@kernel.dk> wrote:
> ...
> > Why not just use an environment variable, like you do for other things?
> > Then just have:
> >
> > verify_only=${VERIFY_ONLY}
> >
> > and you could easily reuse the same job file.
>
> Good idea! That would work. We'll do that next time we update fio if
> there is no verify_only option.
Good, so we're all happy! I'm not adding the command line option if I
can avoid it, it seems redundant and I prefer to keep those options if
they have implicit global scope. The ones that exist and could be
options, I've retained them only to avoid unecessarily breaking peoples
setups.
--
Jens Axboe
next prev parent reply other threads:[~2014-01-24 23:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 21:06 [PATCH] Adds check for numberio during verify phase Juan Casse
2013-09-17 21:06 ` [PATCH V3] Adds verify_only option Juan Casse
2014-01-24 18:34 ` Grant Grundler
2013-09-17 21:06 ` [PATCH] Adds check for rand_seed during verify phase Juan Casse
2014-01-24 18:35 ` Grant Grundler
2014-01-24 18:34 ` [PATCH] Adds check for numberio " Grant Grundler
2014-01-24 18:58 ` Jens Axboe
2014-01-24 19:22 ` Grant Grundler
2014-01-24 20:07 ` Jens Axboe
2014-01-24 20:48 ` Grant Grundler
2014-01-24 21:19 ` Jens Axboe
2014-01-24 22:56 ` Grant Grundler
2014-01-24 23:17 ` Jens Axboe [this message]
2014-01-24 20:27 ` Grant Grundler
-- strict thread matches above, loose matches on Subject: below --
2013-09-06 3:10 Juan Casse
2013-09-16 22:24 ` Juan Casse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124231705.GG9593@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=grundler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.