From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] i915: remove pm_qos request on error Date: Sat, 25 Jan 2014 12:53:56 +0100 Message-ID: <20140125115356.GC9772@phenom.ffwll.local> References: <20140125091336.GA1703@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140125091336.GA1703@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Stanislaw Gruszka Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sat, Jan 25, 2014 at 10:13:37AM +0100, Stanislaw Gruszka wrote: > Not removing pm qos request and free memory for it can cause crash, > when some other driver use pm qos. For example, this oops: > > BUG: unable to handle kernel paging request at fffffffffffffff8 > IP: [] plist_add+0x5b/0xd0 > Call Trace: > [] pm_qos_update_target+0x125/0x1e0 > [] pm_qos_add_request+0x91/0x100 > [] e1000_open+0xe4/0x5b0 [e1000e] > > was caused by earlier i915 probe failure: > > [drm:i915_report_and_clear_eir] *ERROR* EIR stuck: 0x00000010, masking > [drm:init_ring_common] *ERROR* render ring initialization failed ctl 0001f001 head 00003004 tail 00000000 start 00003000 > [drm:i915_driver_load] *ERROR* failed to init modeset > i915: probe of 0000:00:02.0 failed with error -5 > > Bug report: > http://bugzilla.redhat.com/show_bug.cgi?id=1057533 > > Reported-by: Giandomenico De Tullio > Cc: stable@vger.kernel.org > Signed-off-by: Stanislaw Gruszka Picked up for -fixes, thanks for the patch. I've remove the movement of the to pm_qos_add_request though. If we want to clean this is I think an intel_irq_fini which is called both here and in the unload code is better. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch