From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: debugfs: Add support for probing
	DP sink CRC.
Date: Sat, 25 Jan 2014 20:11:26 +0100
Message-ID: <20140125191126.GE9772@phenom.ffwll.local>
References: <20140124124020.GC3514@strange.config>
	<1390577777-3644-1-git-send-email-rodrigo.vivi@gmail.com>
	<20140124154358.GE3514@strange.config>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42])
	by gabe.freedesktop.org (Postfix) with ESMTP id C0AFFFA48E
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 25 Jan 2014 11:11:30 -0800 (PST)
Received: by mail-ee0-f42.google.com with SMTP id e49so1535436eek.29
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 25 Jan 2014 11:11:30 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20140124154358.GE3514@strange.config>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org, Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jan 24, 2014 at 03:43:58PM +0000, Damien Lespiau wrote:
> On Fri, Jan 24, 2014 at 01:36:17PM -0200, Rodrigo Vivi wrote:
> > This debugfs interface will allow intel-gpu-tools test case
> > to verify if screen has been updated properly on cases like PSR.
> > 
> > v2: Accepted all Daniel's suggestions:
> >     * grab modeset lock
> >     * loop over connector and check DPMS on
> >     * return errors
> >     * use _eDP1 suffix for easy future extension
> >     * don't cache crc_supported neither latest crc
> >     * return crc as a full array and read it at once with aux.
> >     * use 0 to turn TEST_SINK off.
> >     * split the drm_helpers definitions in another patch.
> > 
> > v3: Accepted 2 Damien's suggestion: remove h from printf hexa
> >     and return ENODEV when eDP not present instead of EAGAIN.
> > 
> > v4: Accepted 2 Jani' s suggestion: 1 path for unlock and remove
> >     _retry from aux read.
> > 
> > v5: removing last missing useless _retry (by Damien)
> > 
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Damien Lespiau <damien.lespiau@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> 
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch