From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM Date: Sat, 25 Jan 2014 21:48:05 +0100 Message-ID: <20140125204805.GP9772@phenom.ffwll.local> References: <1390616265-4329-1-git-send-email-benjamin.widawsky@intel.com> <52E376A1.8000803@whitecape.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E981FA8EA for ; Sat, 25 Jan 2014 12:48:11 -0800 (PST) Received: by mail-ee0-f54.google.com with SMTP id e53so1563822eek.27 for ; Sat, 25 Jan 2014 12:48:10 -0800 (PST) Content-Disposition: inline In-Reply-To: <52E376A1.8000803@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Kenneth Graunke Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Sat, Jan 25, 2014 at 12:32:33AM -0800, Kenneth Graunke wrote: > On 01/24/2014 06:17 PM, Ben Widawsky wrote: > > From: Chris Wilson > > > > This is useful for debugging as we then know that the first entry is > > always the global GTT, and all later entries the per-process GTT VM. > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Ben Widawsky > > --- > > drivers/gpu/drm/i915/i915_gem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > > index 024e454..946a577 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > @@ -4634,7 +4634,7 @@ void i915_init_vm(struct drm_i915_private *dev_priv, > > INIT_LIST_HEAD(&vm->active_list); > > INIT_LIST_HEAD(&vm->inactive_list); > > INIT_LIST_HEAD(&vm->global_link); > > - list_add(&vm->global_link, &dev_priv->vm_list); > > + list_add_tail(&vm->global_link, &dev_priv->vm_list); > > } > > > > void > > These five patches are: > Tested-by: Kenneth Graunke > > On Broadwell with drm-intel-nightly, I don't get the batchbuffer as part > of my error state, which is a regression. With these patches, it's back > again. > > Thanks for investigating this, Ben. I want to merge Mika's fixes for the reset stats ioctls, mostly since his patches are older and we also have neat testcases for them all. Then we can reconsider the issue here and how to best get at the right batch buffers. If it breaks development just boot with ppgtt=1 for now, for userspace nothing really changes compared to full ppgtt. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch