All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Raghu Gandham <raghu.gandham@imgtec.com>
Cc: aaro.koskinen@iki.fi, linux-input@vger.kernel.org,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions.
Date: Sun, 26 Jan 2014 13:49:53 -0800	[thread overview]
Message-ID: <20140126214952.GD18840@core.coreip.homeip.net> (raw)
In-Reply-To: <1390676514-30880-1-git-send-email-raghu.gandham@imgtec.com>

Hi Raghu,

On Sat, Jan 25, 2014 at 11:01:54AM -0800, Raghu Gandham wrote:
> The standard IO regions are already reserved by the platform code on most MIPS
> devices(malta, cobalt, sni). The Commit 197a1e96c8be5b6005145af3a4c0e45e2d651444
> ("Input: i8042-io - fix up region handling on MIPS") introduced a bug on these
> MIPS platforms causing i8042 driver to fail when trying to reserve IO ports.
> Prior to the above mentioned commit request_region is skipped on MIPS but
> release_region is called.
> 
> This patch reverts commit 197a1e96c8be5b6005145af3a4c0e45e2d651444 and also
> avoids calling release_region for MIPS.

The problem is that IO regions are reserved on _most_, but not _all_
devices. MIPS should figure out what they want to do with i8042
registers and be consistent on all devices.

I do not want to apply this patch because it will be breaking devices
using the other configuration.

Thanks.

-- 
Dmitry

  reply	other threads:[~2014-01-26 21:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-25 19:01 [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions Raghu Gandham
2014-01-25 19:01 ` Raghu Gandham
2014-01-26 21:49 ` Dmitry Torokhov [this message]
2014-01-27  0:32   ` Raghu Gandham
2014-01-27  6:56     ` Dmitry Torokhov
2014-01-27 20:24       ` Aaro Koskinen
2014-01-28  6:25         ` Raghu Gandham
2014-03-19 20:49           ` Ralf Baechle
2014-03-19 23:44             ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140126214952.GD18840@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=raghu.gandham@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.