From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] blkif.h: enhance comments related to the discard feature Date: Mon, 27 Jan 2014 11:24:03 +0100 Message-ID: <20140127102403.GA30713@aepfle.de> References: <1389736679-15637-1-git-send-email-olaf@aepfle.de> <52D955A902000078001149E2@nat28.tlf.novell.com> <20140122211449.GA10426@phenom.dumpdata.com> <52E0DEAC020000780011603E@nat28.tlf.novell.com> <20140124143028.GA12946@phenom.dumpdata.com> <52E28A620200007800116B34@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W7jO9-0003rs-PE for xen-devel@lists.xenproject.org; Mon, 27 Jan 2014 10:25:58 +0000 Content-Disposition: inline In-Reply-To: <52E28A620200007800116B34@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Fri, Jan 24, Jan Beulich wrote: > Not with my reading of it - when using "must", it's clear that both > need to be present. When using "may", one can read it that > providing just one is fine too. But I agree that the wording with > "must" isn't fully correct either. I'd go for "should", and extend the > sentence by "; providing just one of the two may be considered an > error by the frontend". I will make that change. Olaf