From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "François-Frédéric Ozog" <ff-SpBG2i6TTxU@public.gmane.org>,
"'Didier Pallard'"
<didier.pallard-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] timer: add lfence before TSC read
Date: Mon, 27 Jan 2014 10:57:52 +0100 [thread overview]
Message-ID: <201401271057.52251.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <00d201cf18f9$67cdaf10$37690d30$@com>
24/01/2014 12:42, François-Frédéric Ozog:
> IMHO, adding the lfence for all cases is introducing an un-necessary
> performance penalty.
>
> What about adding rte_rdtsc_sync() or rte_rdtsc_serial() with the comment
> about the rdtsc instruction behavior so that developers can choose which
> form they want?
Yes it could be a good idea in some cases. Didier, could you try to add such
function ?
But in some debugging cases we need to have high precision for almost all
timestamps. Here I don't know what is the smartest solution.
Thank you for commenting. Hope we'll find a good fix.
--
Thomas
next prev parent reply other threads:[~2014-01-27 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 11:17 [PATCH] timer: add lfence before TSC read Didier Pallard
[not found] ` <1390562277-24769-1-git-send-email-didier.pallard-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-24 11:42 ` François-Frédéric Ozog
2014-01-24 12:48 ` Ananyev, Konstantin
2014-01-27 9:57 ` Thomas Monjalon [this message]
[not found] ` <201401271057.52251.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-27 11:58 ` didier.pallard
[not found] ` <52E649CD.3090000-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-01-28 1:28 ` Sangjin Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401271057.52251.thomas.monjalon@6wind.com \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=didier.pallard-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
--cc=ff-SpBG2i6TTxU@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.