From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare() Date: Mon, 27 Jan 2014 18:35:57 +0100 Message-ID: <20140127173557.GE4941@twins.programming.kicks-ass.net> References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-2-git-send-email-nicolas.pitre@linaro.org> <52E6175F.1050401@linaro.org> <20140127160736.GP15937@n2100.arm.linux.org.uk> <52E69395.9020004@linaro.org> <20140127172110.GR15937@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140127172110.GR15937@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: Nicolas Pitre , linaro-kernel@lists.linaro.org, linux-sh@vger.kernel.org, Catalin Marinas , linux-pm@vger.kernel.org, Daniel Lezcano , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Paul Mundt , Benjamin Herrenschmidt , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Ingo Molnar , linux-arm-kernel@lists.infradead.org List-Id: linux-pm@vger.kernel.org On Mon, Jan 27, 2014 at 05:21:10PM +0000, Russell King - ARM Linux wrote: > A reviewed-by tag on its own doesn't mean much, as it could mean that > you've just glanced over the code and decided "yea, it looks okay", or > it could mean that you've spent all day verifying that the code change > is indeed correct. One should use Acked-by for the 'yea, it looks okay' thing. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Mon, 27 Jan 2014 17:35:57 +0000 Subject: Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare() Message-Id: <20140127173557.GE4941@twins.programming.kicks-ass.net> List-Id: References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-2-git-send-email-nicolas.pitre@linaro.org> <52E6175F.1050401@linaro.org> <20140127160736.GP15937@n2100.arm.linux.org.uk> <52E69395.9020004@linaro.org> <20140127172110.GR15937@n2100.arm.linux.org.uk> In-Reply-To: <20140127172110.GR15937@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Mon, Jan 27, 2014 at 05:21:10PM +0000, Russell King - ARM Linux wrote: > A reviewed-by tag on its own doesn't mean much, as it could mean that > you've just glanced over the code and decided "yea, it looks okay", or > it could mean that you've spent all day verifying that the code change > is indeed correct. One should use Acked-by for the 'yea, it looks okay' thing. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from merlin.infradead.org (unknown [IPv6:2001:4978:20e::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5CE2F2C0040 for ; Tue, 28 Jan 2014 04:36:22 +1100 (EST) Date: Mon, 27 Jan 2014 18:35:57 +0100 From: Peter Zijlstra To: Russell King - ARM Linux Subject: Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare() Message-ID: <20140127173557.GE4941@twins.programming.kicks-ass.net> References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-2-git-send-email-nicolas.pitre@linaro.org> <52E6175F.1050401@linaro.org> <20140127160736.GP15937@n2100.arm.linux.org.uk> <52E69395.9020004@linaro.org> <20140127172110.GR15937@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140127172110.GR15937@n2100.arm.linux.org.uk> Cc: Nicolas Pitre , linaro-kernel@lists.linaro.org, linux-sh@vger.kernel.org, Catalin Marinas , linux-pm@vger.kernel.org, Daniel Lezcano , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Paul Mundt , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Ingo Molnar , linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 27, 2014 at 05:21:10PM +0000, Russell King - ARM Linux wrote: > A reviewed-by tag on its own doesn't mean much, as it could mean that > you've just glanced over the code and decided "yea, it looks okay", or > it could mean that you've spent all day verifying that the code change > is indeed correct. One should use Acked-by for the 'yea, it looks okay' thing. From mboxrd@z Thu Jan 1 00:00:00 1970 From: peterz@infradead.org (Peter Zijlstra) Date: Mon, 27 Jan 2014 18:35:57 +0100 Subject: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare() In-Reply-To: <20140127172110.GR15937@n2100.arm.linux.org.uk> References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-2-git-send-email-nicolas.pitre@linaro.org> <52E6175F.1050401@linaro.org> <20140127160736.GP15937@n2100.arm.linux.org.uk> <52E69395.9020004@linaro.org> <20140127172110.GR15937@n2100.arm.linux.org.uk> Message-ID: <20140127173557.GE4941@twins.programming.kicks-ass.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 27, 2014 at 05:21:10PM +0000, Russell King - ARM Linux wrote: > A reviewed-by tag on its own doesn't mean much, as it could mean that > you've just glanced over the code and decided "yea, it looks okay", or > it could mean that you've spent all day verifying that the code change > is indeed correct. One should use Acked-by for the 'yea, it looks okay' thing. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754089AbaA0Rga (ORCPT ); Mon, 27 Jan 2014 12:36:30 -0500 Received: from merlin.infradead.org ([205.233.59.134]:33891 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754000AbaA0Rg2 (ORCPT ); Mon, 27 Jan 2014 12:36:28 -0500 Date: Mon, 27 Jan 2014 18:35:57 +0100 From: Peter Zijlstra To: Russell King - ARM Linux Cc: Daniel Lezcano , Nicolas Pitre , Catalin Marinas , Benjamin Herrenschmidt , Paul Mundt , Thomas Gleixner , Ingo Molnar , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare() Message-ID: <20140127173557.GE4941@twins.programming.kicks-ass.net> References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-2-git-send-email-nicolas.pitre@linaro.org> <52E6175F.1050401@linaro.org> <20140127160736.GP15937@n2100.arm.linux.org.uk> <52E69395.9020004@linaro.org> <20140127172110.GR15937@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140127172110.GR15937@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 27, 2014 at 05:21:10PM +0000, Russell King - ARM Linux wrote: > A reviewed-by tag on its own doesn't mean much, as it could mean that > you've just glanced over the code and decided "yea, it looks okay", or > it could mean that you've spent all day verifying that the code change > is indeed correct. One should use Acked-by for the 'yea, it looks okay' thing.