All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/6] *.mk: replace (TARGET|HOST)_PATH by BR2_PATH
Date: Mon, 27 Jan 2014 21:35:57 +0100	[thread overview]
Message-ID: <20140127213557.23be21c9@skate> (raw)
In-Reply-To: <1390074102-15686-2-git-send-email-s.martin49@gmail.com>

Dear Samuel Martin,

On Sat, 18 Jan 2014 20:41:40 +0100, Samuel Martin wrote:
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

Please give a proper commit log for this patch, as well as for PATCH
5/6.

I have already asked multiple times to do this, and you continue to
send patches without a proper commit log. A good rule of thumb is that
*all* commits should always have a non-empty commit log. The commit
title is very often insufficient to explain *why* the commit is made.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-01-27 20:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 19:41 [Buildroot] [PATCH v2 0/6] PATH cleanup Samuel Martin
2014-01-18 19:41 ` [Buildroot] [PATCH v2 3/6] *.mk: replace (TARGET|HOST)_PATH by BR2_PATH Samuel Martin
2014-01-27 20:35   ` Thomas Petazzoni [this message]
2014-01-18 19:41 ` [Buildroot] [PATCH v2 5/6] pkg-cmake.mk: add PATH in the configure command environment Samuel Martin
2014-01-18 19:41 ` [Buildroot] [PATCH v2 6/6] Makefile: export PATH Samuel Martin
2014-01-27 20:34 ` [Buildroot] [PATCH v2 0/6] PATH cleanup Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140127213557.23be21c9@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.