All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>, Wei Ni <wni@nvidia.com>,
	linux-kernel@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] lm90 driver no longer working on PCs in 3.13
Date: Mon, 27 Jan 2014 23:41:35 +0000	[thread overview]
Message-ID: <20140127234135.GA18059@roeck-us.net> (raw)
In-Reply-To: <20140127230447.7e8be3a4@endymion.delvare>

On Mon, Jan 27, 2014 at 11:04:47PM +0100, Jean Delvare wrote:
> On Mon, 27 Jan 2014 10:50:31 -0800, Guenter Roeck wrote:
> > On Mon, Jan 27, 2014 at 10:19:24AM -0700, Stephen Warren wrote:
> > > On 01/26/2014 04:51 PM, Mark Brown wrote:
> > > > On Sun, Jan 26, 2014 at 02:04:06PM -0800, Guenter Roeck wrote:
> > > > 
> > > >> I think I have a better idea: Surround the regulator code, or at least
> > > >> its error handling, in the lm90 driver with
> > > > 
> > > >> 	if (IS_ENABLED(CONFIG_OF)) {
> > > >> 	}
> > > > 
> > > >> Would that be ok ? If yes I'll submit a patch. I'll do the same in
> > > >> another driver I am working on.
> > > > 
> > > > That's not going to have the desired effect in cases where DT is built
> > > > into the kernel but not in use on the current system (which is a
> > > > configuration that gets used) ...
> > > 
> > > The solution to that particular aspect of the problem is the following:
> > > 
> > > if (of_have_populated_dt()) {
> > > 	...
> > > 
> > 
> > Turns out that won't help either after Mark's patches to ACPI and
> > to the regulator core are applied. Right now I don't have a solution
> > that would work for all systems.
> > 
> > I'll leave it up to Jean to decide how to proceed.
> 
> I have no idea, really. I have seen multiple patches flying around,
> each seems to have its own merits, but I simply don't know which is
> going in the direction. I don't know a thing about regulators, OF, DT
> etc. so I am really not the right person to make a decision about this.
> 
> All I can say is: either someone comes up with a patch set which
> properly fixes the regression for all lm90 drivers users, or I will have
> to revert commit 3e0f964f.
> 
I'll test Mark's two patches on my system and let you know the results.
After looking some more into it, those _may_ actually fix the problem at least
for systems supporting ACPI. No promise, though, and I am not sure if that
would be sufficient (it may still not work on non-ACPI PCs). But then who
am I to say ...  Mark keeps repeating that I don't know what I am talking about,
after all, and maybe he has a point ;-).

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>, Wei Ni <wni@nvidia.com>,
	linux-kernel@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] lm90 driver no longer working on PCs in 3.13
Date: Mon, 27 Jan 2014 15:41:35 -0800	[thread overview]
Message-ID: <20140127234135.GA18059@roeck-us.net> (raw)
In-Reply-To: <20140127230447.7e8be3a4@endymion.delvare>

On Mon, Jan 27, 2014 at 11:04:47PM +0100, Jean Delvare wrote:
> On Mon, 27 Jan 2014 10:50:31 -0800, Guenter Roeck wrote:
> > On Mon, Jan 27, 2014 at 10:19:24AM -0700, Stephen Warren wrote:
> > > On 01/26/2014 04:51 PM, Mark Brown wrote:
> > > > On Sun, Jan 26, 2014 at 02:04:06PM -0800, Guenter Roeck wrote:
> > > > 
> > > >> I think I have a better idea: Surround the regulator code, or at least
> > > >> its error handling, in the lm90 driver with
> > > > 
> > > >> 	if (IS_ENABLED(CONFIG_OF)) {
> > > >> 	}
> > > > 
> > > >> Would that be ok ? If yes I'll submit a patch. I'll do the same in
> > > >> another driver I am working on.
> > > > 
> > > > That's not going to have the desired effect in cases where DT is built
> > > > into the kernel but not in use on the current system (which is a
> > > > configuration that gets used) ...
> > > 
> > > The solution to that particular aspect of the problem is the following:
> > > 
> > > if (of_have_populated_dt()) {
> > > 	...
> > > 
> > 
> > Turns out that won't help either after Mark's patches to ACPI and
> > to the regulator core are applied. Right now I don't have a solution
> > that would work for all systems.
> > 
> > I'll leave it up to Jean to decide how to proceed.
> 
> I have no idea, really. I have seen multiple patches flying around,
> each seems to have its own merits, but I simply don't know which is
> going in the direction. I don't know a thing about regulators, OF, DT
> etc. so I am really not the right person to make a decision about this.
> 
> All I can say is: either someone comes up with a patch set which
> properly fixes the regression for all lm90 drivers users, or I will have
> to revert commit 3e0f964f.
> 
I'll test Mark's two patches on my system and let you know the results.
After looking some more into it, those _may_ actually fix the problem at least
for systems supporting ACPI. No promise, though, and I am not sure if that
would be sufficient (it may still not work on non-ACPI PCs). But then who
am I to say ...  Mark keeps repeating that I don't know what I am talking about,
after all, and maybe he has a point ;-).

Guenter

  reply	other threads:[~2014-01-27 23:41 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-26 19:28 [lm-sensors] lm90 driver no longer working on PCs in 3.13 Guenter Roeck
2014-01-26 19:28 ` Guenter Roeck
2014-01-26 20:13 ` [lm-sensors] " Jean Delvare
2014-01-26 20:13   ` Jean Delvare
2014-01-26 20:42   ` [lm-sensors] " Mark Brown
2014-01-26 20:42     ` Mark Brown
2014-01-26 20:44   ` [lm-sensors] " Guenter Roeck
2014-01-26 20:44     ` Guenter Roeck
2014-01-26 20:49     ` [lm-sensors] " Jean Delvare
2014-01-26 20:49       ` Jean Delvare
2014-01-26 21:22       ` [lm-sensors] " Mark Brown
2014-01-26 21:22         ` Mark Brown
2014-01-26 21:40         ` [lm-sensors] " Guenter Roeck
2014-01-26 21:40           ` Guenter Roeck
2014-01-26 21:53           ` [lm-sensors] " Mark Brown
2014-01-26 21:53             ` Mark Brown
2014-01-26 22:02             ` [lm-sensors] " Guenter Roeck
2014-01-26 22:02               ` Guenter Roeck
2014-01-26 23:37               ` [lm-sensors] " Mark Brown
2014-01-26 23:37                 ` Mark Brown
2014-01-26 21:44         ` [lm-sensors] " Jean Delvare
2014-01-26 21:44           ` Jean Delvare
2014-01-26 23:15           ` [lm-sensors] " Mark Brown
2014-01-26 23:15             ` Mark Brown
2014-01-27 10:10             ` [lm-sensors] " Geert Uytterhoeven
2014-01-27 10:10               ` Geert Uytterhoeven
2014-01-27 13:18               ` [lm-sensors] " Mark Brown
2014-01-27 13:18                 ` Mark Brown
2014-01-26 21:50       ` [lm-sensors] " Guenter Roeck
2014-01-26 21:50         ` Guenter Roeck
2014-01-26 22:04         ` [lm-sensors] " Guenter Roeck
2014-01-26 22:04           ` Guenter Roeck
2014-01-26 23:51           ` Mark Brown
2014-01-26 23:51             ` Mark Brown
2014-01-27  4:16             ` Guenter Roeck
2014-01-27  4:16               ` Guenter Roeck
2014-01-27 10:34               ` Mark Brown
2014-01-27 10:34                 ` Mark Brown
2014-01-27 17:19             ` Stephen Warren
2014-01-27 17:19               ` Stephen Warren
2014-01-27 18:50               ` Guenter Roeck
2014-01-27 18:50                 ` Guenter Roeck
2014-01-27 22:04                 ` Jean Delvare
2014-01-27 22:04                   ` Jean Delvare
2014-01-27 23:41                   ` Guenter Roeck [this message]
2014-01-27 23:41                     ` Guenter Roeck
2014-01-27 23:58                     ` Mark Brown
2014-01-27 23:58                       ` Mark Brown
2014-01-28  2:33                       ` Guenter Roeck
2014-01-28  2:33                         ` Guenter Roeck
2014-01-28 10:24                         ` Mark Brown
2014-01-28 10:24                           ` Mark Brown
2014-01-28 12:34                   ` Mark Brown
2014-01-28 12:34                     ` Mark Brown
2014-01-27 22:36                 ` Mark Brown
2014-01-27 22:36                   ` Mark Brown
2014-01-26 20:52     ` Mark Brown
2014-01-26 20:52       ` Mark Brown
2014-01-26 21:47       ` [lm-sensors] " Guenter Roeck
2014-01-26 21:47         ` Guenter Roeck
2014-01-26 22:01         ` [lm-sensors] " Mark Brown
2014-01-26 22:01           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140127234135.GA18059@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=broonie@kernel.org \
    --cc=khali@linux-fr.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=swarren@wwwdotorg.org \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.