From: Dave Jones <davej@redhat.com>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
akpm@linux-foundation.org, zhangyanfei@cn.fujitsu.com,
guz.fnst@cn.fujitsu.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] numa, mem-hotplug: Fix stack overflow in numa when seting kernel nodes to unhotpluggable.
Date: Tue, 28 Jan 2014 01:53:16 -0500 [thread overview]
Message-ID: <20140128065316.GB27636@redhat.com> (raw)
In-Reply-To: <52E73D61.8000304@cn.fujitsu.com>
On Tue, Jan 28, 2014 at 01:17:21PM +0800, Tang Chen wrote:
> Seeing from your earlier mail, it crashed at:
>
> while (zonelist_zone_idx(z) > highest_zoneidx)
> de: 3b 77 08 cmp 0x8(%rdi),%esi
>
>
> I stuck this at the top of the function..
>
> printk(KERN_ERR "z:%p nodes:%p highest:%d\n", z, nodes, highest_zoneidx);
>
> and got
>
> z: 1d08 nodes: (null) highest:3
>
>
> nodes=null and highest=3, they are correct. When looking into
> next_zones_zonelist(),
> I cannot see why it crashed. So, can you print the zone id in the
> for_each_zone_zonelist() loop in nr_free_zone_pages() ?
> I want to know why it crashed. A NULL pointer ? Which one ?
It's not so easy further in the function, because the oops scrolls off
any useful printks, there's no scrollback, and no logging..
I even tried adding some udelays to slow things down (and using boot_delay)
but that makes things just hang seemingly indefinitly.
What about that 'z' ptr though ? 0x1d08 seems like a strange address
for us to have a structure at, though I'm not too familiar with the early
boot code, so maybe we do have something down there ?
Dave
next prev parent reply other threads:[~2014-01-28 6:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 5:49 [PATCH] numa, mem-hotplug: Fix stack overflow in numa when seting kernel nodes to unhotpluggable Tang Chen
2014-01-23 6:01 ` Dave Jones
2014-01-23 6:05 ` Andrew Morton
2014-01-23 6:06 ` David Rientjes
2014-01-23 6:13 ` Dave Jones
2014-01-23 6:15 ` David Rientjes
2014-01-23 6:58 ` Dave Jones
2014-01-23 22:31 ` Dave Jones
2014-01-27 7:29 ` Tang Chen
2014-01-27 14:52 ` Dave Jones
2014-01-23 6:36 ` Tang Chen
2014-01-28 0:32 ` David Rientjes
2014-01-28 1:01 ` Tang Chen
2014-01-28 2:55 ` Dave Jones
2014-01-28 3:14 ` Tang Chen
2014-01-28 3:24 ` Tang Chen
2014-01-28 3:55 ` Dave Jones
2014-01-28 4:47 ` Tang Chen
2014-01-28 4:47 ` Dave Jones
2014-01-28 5:17 ` Tang Chen
2014-01-28 6:53 ` Dave Jones [this message]
2014-01-28 5:31 ` Tang Chen
2014-01-28 7:10 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128065316.GB27636@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.