From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 16/28] drm/i915: WaApplyL3ControlAndL3ChickenMode isn't applicable for VLV Date: Tue, 28 Jan 2014 16:32:26 +0100 Message-ID: <20140128153225.GC7444@phenom.ffwll.local> References: <1390419184-4450-1-git-send-email-ville.syrjala@linux.intel.com> <1390419184-4450-17-git-send-email-ville.syrjala@linux.intel.com> <20140128132352.GA7444@phenom.ffwll.local> <20140128141352.GA9454@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com [209.85.217.169]) by gabe.freedesktop.org (Postfix) with ESMTP id A4753FB848 for ; Tue, 28 Jan 2014 07:32:31 -0800 (PST) Received: by mail-lb0-f169.google.com with SMTP id q8so485795lbi.0 for ; Tue, 28 Jan 2014 07:32:30 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140128141352.GA9454@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 28, 2014 at 04:13:52PM +0200, Ville Syrj=E4l=E4 wrote: > On Tue, Jan 28, 2014 at 02:24:42PM +0100, Daniel Vetter wrote: > > On Wed, Jan 22, 2014 at 09:32:52PM +0200, ville.syrjala@linux.intel.com= wrote: > > > From: Ville Syrj=E4l=E4 > > > = > > > WaApplyL3ControlAndL3ChickenMode is only listed for IVB and HSW in > > > W/A database and BSpec. > > > = > > > Signed-off-by: Ville Syrj=E4l=E4 > > > --- > > > drivers/gpu/drm/i915/intel_pm.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > = > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/i= ntel_pm.c > > > index 895046f..62d339b 100644 > > > --- a/drivers/gpu/drm/i915/intel_pm.c > > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > > @@ -4930,8 +4930,6 @@ static void valleyview_init_clock_gating(struct= drm_device *dev) > > > = > > > /* WaDisableL3CacheAging:vlv */ > > > I915_WRITE(GEN7_L3CNTLREG1, I915_READ(GEN7_L3CNTLREG1) | GEN7_L3AGD= IS); > > > - /* WaApplyL3ControlAndL3ChickenMode:vlv */ > > > - I915_WRITE(GEN7_L3_CHICKEN_MODE_REGISTER, GEN7_WA_L3_CHICKEN_MODE); > > = > > This one doesn't seem to be here ... is some earlier patch which I have= n't > > merged yet adding this? Can't we just fold this in? > = > ? I see you alreay applied this patch. Are ou trying to put it in twice? > IIRC in the past we applied one workaround three times, now we're trying > to not apply one twice :) Oh right, Rodrigo reviewed this one yesterday already. Sorry for the confusion ;-) -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch