From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Tue, 28 Jan 2014 18:12:18 +0100 Subject: [PATCH v3 07/24] drm/i2c: tda998x: set the video mode from the adjusted value In-Reply-To: <20140123232907.GA25988@ti.com> References: <20140119195840.1ecab03b@armhf> <20140123232907.GA25988@ti.com> Message-ID: <20140128181218.39d1d15e@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 23 Jan 2014 17:29:07 -0600 Darren Etheridge wrote: > > @@ -896,9 +897,9 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, > > * TDA19988 requires high-active sync at input stage, > > * so invert low-active sync provided by master encoder here > > */ > > - if (mode->flags & DRM_MODE_FLAG_NHSYNC) > > + if (adj_mode->flags & DRM_MODE_FLAG_NHSYNC) > > reg_set(priv, REG_VIP_CNTRL_3, VIP_CNTRL_3_H_TGL); > > - if (mode->flags & DRM_MODE_FLAG_NVSYNC) > > + if (adj_mode->flags & DRM_MODE_FLAG_NVSYNC) > > reg_set(priv, REG_VIP_CNTRL_3, VIP_CNTRL_3_V_TGL); > > > > Using the adj_mode->flags breaks a workaround I had done on BeagleBone Black > (tilcdc + tda998x) to resolve an issue with out of spec syncs from the > tlcdc. I invert the HSYNC in adj_mode->flags but don't want the tda998x to > really know that I am doing that so I use adj_mode in the tilcdc driver, and > mode here in the tda998x driver. The theory being adj_mode contains whatever > workarounds I need to do for the driving device and mode has the pristine > values that I want to send to the monitor. I would need to look if there is a > different way to solve this as I am guessing you are actually using adj_mode in > the manner it was intended. No. In fact, I just wanted the function to use only one mode. Looking at the other drivers, it seems that they don't touch the adjusted_mode, so, for the Cubox, mode and adjusted_mode have same values. I will do an other patch so that you will not have to touch the tilcdc driver. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v3 07/24] drm/i2c: tda998x: set the video mode from the adjusted value Date: Tue, 28 Jan 2014 18:12:18 +0100 Message-ID: <20140128181218.39d1d15e@armhf> References: <20140119195840.1ecab03b@armhf> <20140123232907.GA25988@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [212.27.42.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFC80FBFE8 for ; Tue, 28 Jan 2014 09:12:09 -0800 (PST) In-Reply-To: <20140123232907.GA25988@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Darren Etheridge Cc: linux-arm-kernel@lists.infradead.org, balbi@ti.com, Russell King - ARM Linux , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMyBKYW4gMjAxNCAxNzoyOTowNyAtMDYwMApEYXJyZW4gRXRoZXJpZGdlIDxkZXRo ZXJpZGdlQHRpLmNvbT4gd3JvdGU6Cgo+ID4gQEAgLTg5Niw5ICs4OTcsOSBAQCB0ZGE5OTh4X2Vu Y29kZXJfbW9kZV9zZXQoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ID4gIAkgKiBUREEx OTk4OCByZXF1aXJlcyBoaWdoLWFjdGl2ZSBzeW5jIGF0IGlucHV0IHN0YWdlLAo+ID4gIAkgKiBz byBpbnZlcnQgbG93LWFjdGl2ZSBzeW5jIHByb3ZpZGVkIGJ5IG1hc3RlciBlbmNvZGVyIGhlcmUK PiA+ICAJICovCj4gPiAtCWlmIChtb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfTkhTWU5DKQo+ ID4gKwlpZiAoYWRqX21vZGUtPmZsYWdzICYgRFJNX01PREVfRkxBR19OSFNZTkMpCj4gPiAgCQly ZWdfc2V0KHByaXYsIFJFR19WSVBfQ05UUkxfMywgVklQX0NOVFJMXzNfSF9UR0wpOwo+ID4gLQlp ZiAobW9kZS0+ZmxhZ3MgJiBEUk1fTU9ERV9GTEFHX05WU1lOQykKPiA+ICsJaWYgKGFkal9tb2Rl LT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfTlZTWU5DKQo+ID4gIAkJcmVnX3NldChwcml2LCBSRUdf VklQX0NOVFJMXzMsIFZJUF9DTlRSTF8zX1ZfVEdMKTsKPiA+ICAgIAo+IAo+IFVzaW5nIHRoZSBh ZGpfbW9kZS0+ZmxhZ3MgYnJlYWtzIGEgd29ya2Fyb3VuZCBJIGhhZCBkb25lIG9uIEJlYWdsZUJv bmUgQmxhY2sKPiAodGlsY2RjICsgdGRhOTk4eCkgdG8gcmVzb2x2ZSBhbiBpc3N1ZSB3aXRoIG91 dCBvZiBzcGVjIHN5bmNzIGZyb20gdGhlCj4gdGxjZGMuICBJIGludmVydCB0aGUgSFNZTkMgaW4g YWRqX21vZGUtPmZsYWdzIGJ1dCBkb24ndCB3YW50IHRoZSB0ZGE5OTh4IHRvCj4gcmVhbGx5IGtu b3cgdGhhdCBJIGFtIGRvaW5nIHRoYXQgc28gSSB1c2UgYWRqX21vZGUgaW4gdGhlIHRpbGNkYyBk cml2ZXIsIGFuZAo+IG1vZGUgaGVyZSBpbiB0aGUgdGRhOTk4eCBkcml2ZXIuICBUaGUgdGhlb3J5 IGJlaW5nIGFkal9tb2RlIGNvbnRhaW5zIHdoYXRldmVyCj4gd29ya2Fyb3VuZHMgSSBuZWVkIHRv IGRvIGZvciB0aGUgZHJpdmluZyBkZXZpY2UgYW5kIG1vZGUgaGFzIHRoZSBwcmlzdGluZQo+IHZh bHVlcyB0aGF0IEkgd2FudCB0byBzZW5kIHRvIHRoZSBtb25pdG9yLiAgSSB3b3VsZCBuZWVkIHRv IGxvb2sgaWYgdGhlcmUgaXMgYQo+IGRpZmZlcmVudCB3YXkgdG8gc29sdmUgdGhpcyBhcyBJIGFt IGd1ZXNzaW5nIHlvdSBhcmUgYWN0dWFsbHkgdXNpbmcgYWRqX21vZGUgaW4KPiB0aGUgbWFubmVy IGl0IHdhcyBpbnRlbmRlZC4KCk5vLiBJbiBmYWN0LCBJIGp1c3Qgd2FudGVkIHRoZSBmdW5jdGlv biB0byB1c2Ugb25seSBvbmUgbW9kZS4KCkxvb2tpbmcgYXQgdGhlIG90aGVyIGRyaXZlcnMsIGl0 IHNlZW1zIHRoYXQgdGhleSBkb24ndCB0b3VjaCB0aGUKYWRqdXN0ZWRfbW9kZSwgc28sIGZvciB0 aGUgQ3Vib3gsIG1vZGUgYW5kIGFkanVzdGVkX21vZGUgaGF2ZSBzYW1lCnZhbHVlcy4KCkkgd2ls bCBkbyBhbiBvdGhlciBwYXRjaCBzbyB0aGF0IHlvdSB3aWxsIG5vdCBoYXZlIHRvIHRvdWNoIHRo ZSB0aWxjZGMKZHJpdmVyLgoKLS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAgICAqKiBCcmVpemgg aGEgTGludXggYXRhdiEgKioKSmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVlLmZyLwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755409AbaA1RMO (ORCPT ); Tue, 28 Jan 2014 12:12:14 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]:46490 "EHLO smtp1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755143AbaA1RMM convert rfc822-to-8bit (ORCPT ); Tue, 28 Jan 2014 12:12:12 -0500 Date: Tue, 28 Jan 2014 18:12:18 +0100 From: Jean-Francois Moine To: Darren Etheridge Cc: , Russell King - ARM Linux , , , Subject: Re: [PATCH v3 07/24] drm/i2c: tda998x: set the video mode from the adjusted value Message-ID: <20140128181218.39d1d15e@armhf> In-Reply-To: <20140123232907.GA25988@ti.com> References: <20140119195840.1ecab03b@armhf> <20140123232907.GA25988@ti.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jan 2014 17:29:07 -0600 Darren Etheridge wrote: > > @@ -896,9 +897,9 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder, > > * TDA19988 requires high-active sync at input stage, > > * so invert low-active sync provided by master encoder here > > */ > > - if (mode->flags & DRM_MODE_FLAG_NHSYNC) > > + if (adj_mode->flags & DRM_MODE_FLAG_NHSYNC) > > reg_set(priv, REG_VIP_CNTRL_3, VIP_CNTRL_3_H_TGL); > > - if (mode->flags & DRM_MODE_FLAG_NVSYNC) > > + if (adj_mode->flags & DRM_MODE_FLAG_NVSYNC) > > reg_set(priv, REG_VIP_CNTRL_3, VIP_CNTRL_3_V_TGL); > > > > Using the adj_mode->flags breaks a workaround I had done on BeagleBone Black > (tilcdc + tda998x) to resolve an issue with out of spec syncs from the > tlcdc. I invert the HSYNC in adj_mode->flags but don't want the tda998x to > really know that I am doing that so I use adj_mode in the tilcdc driver, and > mode here in the tda998x driver. The theory being adj_mode contains whatever > workarounds I need to do for the driving device and mode has the pristine > values that I want to send to the monitor. I would need to look if there is a > different way to solve this as I am guessing you are actually using adj_mode in > the manner it was intended. No. In fact, I just wanted the function to use only one mode. Looking at the other drivers, it seems that they don't touch the adjusted_mode, so, for the Cubox, mode and adjusted_mode have same values. I will do an other patch so that you will not have to touch the tilcdc driver. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/