* [PATCH] fmc: Fix decimal permissions
@ 2014-01-28 18:41 Joe Perches
2014-01-28 19:37 ` Alessandro Rubini
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2014-01-28 18:41 UTC (permalink / raw)
To: Alessandro Rubini; +Cc: LKML
This 444 should have been octal.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/fmc/fmc-write-eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fmc/fmc-write-eeprom.c b/drivers/fmc/fmc-write-eeprom.c
index 30e451e..1f107fb 100644
--- a/drivers/fmc/fmc-write-eeprom.c
+++ b/drivers/fmc/fmc-write-eeprom.c
@@ -26,7 +26,7 @@ FMC_PARAM_BUSID(fwe_drv);
/* The "file=" is like the generic "gateware=" used elsewhere */
static char *fwe_file[FMC_MAX_CARDS];
static int fwe_file_n;
-module_param_array_named(file, fwe_file, charp, &fwe_file_n, 444);
+module_param_array_named(file, fwe_file, charp, &fwe_file_n, 0444);
static int fwe_run_tlv(struct fmc_device *fmc, const struct firmware *fw,
int write)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fmc: Fix decimal permissions
2014-01-28 18:41 [PATCH] fmc: Fix decimal permissions Joe Perches
@ 2014-01-28 19:37 ` Alessandro Rubini
0 siblings, 0 replies; 2+ messages in thread
From: Alessandro Rubini @ 2014-01-28 19:37 UTC (permalink / raw)
To: joe; +Cc: linux-kernel
> This 444 should have been octal.
Right, my fault. We are not using the sysfs interface for module
parameters, so I didn't notice.
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Alessandro Rubini <rubini@gnudd.com>
thanks
/alessandro, with two other minor fmc fixes to submit soon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-28 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28 18:41 [PATCH] fmc: Fix decimal permissions Joe Perches
2014-01-28 19:37 ` Alessandro Rubini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.