From: Jens Axboe <axboe@kernel.dk>
To: Grant Grundler <grundler@chromium.org>
Cc: FIO List <fio@vger.kernel.org>,
Puthikorn Voravootivat <puthik@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH] fio: consolidate rand_seed to uint64_t
Date: Tue, 28 Jan 2014 14:30:14 -0700 [thread overview]
Message-ID: <20140128213014.GC31710@kernel.dk> (raw)
In-Reply-To: <1390942940-6886-1-git-send-email-grundler@chromium.org>
On Tue, Jan 28 2014, Grant Grundler wrote:
> csscope showed rand_seed was defined 4 times - each a different type.
> While they are used differently, the places where they overlap
> should reference the same type. This patch makes three of them the same
> as suggested by Jens Axboe.
Time for public shaming, as you did not even compile this patch! I'll
let you figure out the issue :-)
--
Jens Axboe
next prev parent reply other threads:[~2014-01-28 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 21:02 [PATCH] fio: consolidate rand_seed to uint64_t Grant Grundler
2014-01-28 21:30 ` Jens Axboe [this message]
2014-01-28 21:52 ` Grant Grundler
2014-01-28 22:03 ` Jens Axboe
2014-01-28 22:14 ` Grant Grundler
2014-01-28 22:17 ` Jens Axboe
2014-01-28 22:23 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128213014.GC31710@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=grundler@chromium.org \
--cc=gwendal@chromium.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.