* Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
@ 2014-01-28 21:45 ` Tejun Heo
0 siblings, 0 replies; 9+ messages in thread
From: Tejun Heo @ 2014-01-28 21:45 UTC (permalink / raw)
To: Andi Kleen
Cc: Li Zefan, Wu Fengguang, Andrew Morton, Johannes Weiner,
Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki,
cgroups-u79uwXL29TY76Z2rM5mHXA, linux-mm-Bw31MaZKKs3YtjvyW6yDsg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hello, Andi, Wu.
Can you guys please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup
filter"), which reaches into cgroup to extract the inode number and
uses that for filtering? Nobody outside cgroup proper should be
reaching into that. In fact, the hard association between vfs objects
and cgroup objects are going away in the upcoming devel cycle. If you
want to tag on memcg for filtering, please introduce a proper memcg
knob.
Thank you.
--
tejun
^ permalink raw reply [flat|nested] 9+ messages in thread* Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
@ 2014-01-28 21:45 ` Tejun Heo
0 siblings, 0 replies; 9+ messages in thread
From: Tejun Heo @ 2014-01-28 21:45 UTC (permalink / raw)
To: Andi Kleen
Cc: Li Zefan, Wu Fengguang, Andrew Morton, Johannes Weiner,
Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki, cgroups, linux-mm,
linux-kernel
Hello, Andi, Wu.
Can you guys please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup
filter"), which reaches into cgroup to extract the inode number and
uses that for filtering? Nobody outside cgroup proper should be
reaching into that. In fact, the hard association between vfs objects
and cgroup objects are going away in the upcoming devel cycle. If you
want to tag on memcg for filtering, please introduce a proper memcg
knob.
Thank you.
--
tejun
^ permalink raw reply [flat|nested] 9+ messages in thread* Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
@ 2014-01-28 21:45 ` Tejun Heo
0 siblings, 0 replies; 9+ messages in thread
From: Tejun Heo @ 2014-01-28 21:45 UTC (permalink / raw)
To: Andi Kleen
Cc: Li Zefan, Wu Fengguang, Andrew Morton, Johannes Weiner,
Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki, cgroups, linux-mm,
linux-kernel
Hello, Andi, Wu.
Can you guys please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup
filter"), which reaches into cgroup to extract the inode number and
uses that for filtering? Nobody outside cgroup proper should be
reaching into that. In fact, the hard association between vfs objects
and cgroup objects are going away in the upcoming devel cycle. If you
want to tag on memcg for filtering, please introduce a proper memcg
knob.
Thank you.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
2014-01-28 21:45 ` Tejun Heo
@ 2014-01-28 21:53 ` Andi Kleen
-1 siblings, 0 replies; 9+ messages in thread
From: Andi Kleen @ 2014-01-28 21:53 UTC (permalink / raw)
To: Tejun Heo
Cc: Andi Kleen, Li Zefan, Wu Fengguang, Andrew Morton,
Johannes Weiner, Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki,
cgroups, linux-mm, linux-kernel, gong.chen
On Tue, Jan 28, 2014 at 04:45:24PM -0500, Tejun Heo wrote:
> Hello, Andi, Wu.
>
> Can you guys please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup
> filter"), which reaches into cgroup to extract the inode number and
> uses that for filtering? Nobody outside cgroup proper should be
Our test suite relies on it.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
@ 2014-01-28 21:53 ` Andi Kleen
0 siblings, 0 replies; 9+ messages in thread
From: Andi Kleen @ 2014-01-28 21:53 UTC (permalink / raw)
To: Tejun Heo
Cc: Andi Kleen, Li Zefan, Wu Fengguang, Andrew Morton,
Johannes Weiner, Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki,
cgroups, linux-mm, linux-kernel, gong.chen
On Tue, Jan 28, 2014 at 04:45:24PM -0500, Tejun Heo wrote:
> Hello, Andi, Wu.
>
> Can you guys please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup
> filter"), which reaches into cgroup to extract the inode number and
> uses that for filtering? Nobody outside cgroup proper should be
Our test suite relies on it.
-Andi
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
2014-01-28 21:53 ` Andi Kleen
@ 2014-01-28 21:56 ` Tejun Heo
-1 siblings, 0 replies; 9+ messages in thread
From: Tejun Heo @ 2014-01-28 21:56 UTC (permalink / raw)
To: Andi Kleen
Cc: Li Zefan, Wu Fengguang, Andrew Morton, Johannes Weiner,
Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki, cgroups, linux-mm,
linux-kernel, gong.chen
On Tue, Jan 28, 2014 at 10:53:17PM +0100, Andi Kleen wrote:
> On Tue, Jan 28, 2014 at 04:45:24PM -0500, Tejun Heo wrote:
> > Hello, Andi, Wu.
> >
> > Can you guys please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup
> > filter"), which reaches into cgroup to extract the inode number and
> > uses that for filtering? Nobody outside cgroup proper should be
>
> Our test suite relies on it.
Hmmm? Ooh, I thought this just went in during this -rc1 window. This
was way back in 2009. I suppose cgroup should expose an interface to
query inode then. inos changing across remounts should be okay,
right?
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
@ 2014-01-28 21:56 ` Tejun Heo
0 siblings, 0 replies; 9+ messages in thread
From: Tejun Heo @ 2014-01-28 21:56 UTC (permalink / raw)
To: Andi Kleen
Cc: Li Zefan, Wu Fengguang, Andrew Morton, Johannes Weiner,
Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki, cgroups, linux-mm,
linux-kernel, gong.chen
On Tue, Jan 28, 2014 at 10:53:17PM +0100, Andi Kleen wrote:
> On Tue, Jan 28, 2014 at 04:45:24PM -0500, Tejun Heo wrote:
> > Hello, Andi, Wu.
> >
> > Can you guys please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup
> > filter"), which reaches into cgroup to extract the inode number and
> > uses that for filtering? Nobody outside cgroup proper should be
>
> Our test suite relies on it.
Hmmm? Ooh, I thought this just went in during this -rc1 window. This
was way back in 2009. I suppose cgroup should expose an interface to
query inode then. inos changing across remounts should be okay,
right?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
2014-01-28 21:56 ` Tejun Heo
@ 2014-01-28 21:57 ` Andi Kleen
-1 siblings, 0 replies; 9+ messages in thread
From: Andi Kleen @ 2014-01-28 21:57 UTC (permalink / raw)
To: Tejun Heo
Cc: Andi Kleen, Li Zefan, Wu Fengguang, Andrew Morton,
Johannes Weiner, Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki,
cgroups, linux-mm, linux-kernel, gong.chen
> inos changing across remounts should be okay,
> right?
Yes that's fine.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter")
@ 2014-01-28 21:57 ` Andi Kleen
0 siblings, 0 replies; 9+ messages in thread
From: Andi Kleen @ 2014-01-28 21:57 UTC (permalink / raw)
To: Tejun Heo
Cc: Andi Kleen, Li Zefan, Wu Fengguang, Andrew Morton,
Johannes Weiner, Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki,
cgroups, linux-mm, linux-kernel, gong.chen
> inos changing across remounts should be okay,
> right?
Yes that's fine.
-Andi
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-01-28 21:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28 21:45 Please revert 4fd466eb46a6 ("HWPOISON: add memory cgroup filter") Tejun Heo
2014-01-28 21:45 ` Tejun Heo
2014-01-28 21:45 ` Tejun Heo
2014-01-28 21:53 ` Andi Kleen
2014-01-28 21:53 ` Andi Kleen
2014-01-28 21:56 ` Tejun Heo
2014-01-28 21:56 ` Tejun Heo
2014-01-28 21:57 ` Andi Kleen
2014-01-28 21:57 ` Andi Kleen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.