From: Arnd Bergmann <arnd@arndb.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Pratyush Anand <pratyush.anand@st.com>,
Mohit Kumar <mohit.kumar@st.com>,
linux-kernel@vger.kernel.org
Subject: Re: Query: Phy: How to find consumer device on dt platform
Date: Tue, 28 Jan 2014 22:26:24 +0100 [thread overview]
Message-ID: <201401282226.24197.arnd@arndb.de> (raw)
In-Reply-To: <52E7BE91.8030209@ti.com>
On Tuesday 28 January 2014, Kishon Vijay Abraham I wrote:
> > I have a common set of registers, which need to be programmed
> > differently for PCIe and SATA during phy init/exit.
>
> One way is differentiate using different compatible strings fro pcie and sata
> and use of_device_is_compatible to select a particular path.
But if the IP block is the same, the compatible string should be
identical.
> > Therefore, in the init/exit routine of phy_ops, I need some way of
> > identifying that phy_init/exit has been called from PCIe driver or
> > SATA driver.
>
> In this case you'll be actually registering two different PHYs (each for pcie
> and sata), so your phy_get should give you the only the appropriate phy.
I would instead recommend making the mode of the PHY device the
argument to the phy handle in DT, so that the sata node uses
phys = <&phyA 0>;
and the PCIe node uses
phys = <&phyB 1>;
Then the binding for the phy defines that an argument of '0' means sata mode,
while '1' means pcie mode, plus you should define all other valid modes.
Arnd
next prev parent reply other threads:[~2014-01-28 21:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 14:13 Query: Phy: How to find consumer device on dt platform Pratyush Anand
2014-01-28 14:28 ` Kishon Vijay Abraham I
2014-01-28 21:26 ` Arnd Bergmann [this message]
2014-01-29 5:41 ` Kishon Vijay Abraham I
2014-01-29 9:50 ` Pratyush Anand
2014-01-29 14:24 ` Arnd Bergmann
2014-01-29 14:17 ` Pratyush Anand
2014-01-29 13:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401282226.24197.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mohit.kumar@st.com \
--cc=pratyush.anand@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.