From: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 6/8] cgroup: remove cgroup->name
Date: Wed, 29 Jan 2014 11:47:12 +0100 [thread overview]
Message-ID: <20140129104712.GD9636@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1390953585-16554-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Tue, Jan 28, 2014 at 06:59:43PM -0500, Tejun Heo wrote:
> cgroup->name handling became quite complicated over time involving
> dedicated struct cgroup_name for RCU protection. Now that cgroup is
> on kernfs, we can drop all of it and simply use kernfs_name/path() and
> friends. Replace cgroup->name and all related code with kernfs
> name/path constructs.
>
> * Reimplement cgroup_name() and cgroup_path() as thin wrappers on top
> of kernfs counterparts, which involves semantic changes.
> pr_cont_cgroup_name() and pr_cont_cgroup_path() added.
>
> * cgroup->name handling dropped from cgroup_rename().
>
> * All users of cgroup_name/path() updated to the new semantics. Users
> which were formatting the string just to printk them are converted
> to use pr_cont_cgroup_name/path() instead, which simplifies things
> quite a bit. As cgroup_name() no longer requires RCU read lock
> around it, RCU lockings which were protecting only cgroup_name() are
> removed.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> Cc: Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
> Cc: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
> Cc: Balbir Singh <bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Acked-by: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: lizefan@huawei.com, containers@lists.linux-foundation.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Balbir Singh <bsingharora@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 6/8] cgroup: remove cgroup->name
Date: Wed, 29 Jan 2014 11:47:12 +0100 [thread overview]
Message-ID: <20140129104712.GD9636@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1390953585-16554-7-git-send-email-tj@kernel.org>
On Tue, Jan 28, 2014 at 06:59:43PM -0500, Tejun Heo wrote:
> cgroup->name handling became quite complicated over time involving
> dedicated struct cgroup_name for RCU protection. Now that cgroup is
> on kernfs, we can drop all of it and simply use kernfs_name/path() and
> friends. Replace cgroup->name and all related code with kernfs
> name/path constructs.
>
> * Reimplement cgroup_name() and cgroup_path() as thin wrappers on top
> of kernfs counterparts, which involves semantic changes.
> pr_cont_cgroup_name() and pr_cont_cgroup_path() added.
>
> * cgroup->name handling dropped from cgroup_rename().
>
> * All users of cgroup_name/path() updated to the new semantics. Users
> which were formatting the string just to printk them are converted
> to use pr_cont_cgroup_name/path() instead, which simplifies things
> quite a bit. As cgroup_name() no longer requires RCU read lock
> around it, RCU lockings which were protecting only cgroup_name() are
> removed.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@suse.cz>
> Cc: Balbir Singh <bsingharora@gmail.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
next prev parent reply other threads:[~2014-01-29 10:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 23:59 [PATCHSET cgroup/for-3.15] cgroup: cleanups after kernfs conversion Tejun Heo
2014-01-28 23:59 ` Tejun Heo
2014-01-28 23:59 ` [PATCH 5/8] cgroup: make cgroup hold onto its kernfs_node Tejun Heo
[not found] ` <1390953585-16554-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-01-28 23:59 ` [PATCH 1/8] cgroup: warn if "xattr" is specified with "sane_behavior" Tejun Heo
2014-01-28 23:59 ` Tejun Heo
2014-01-28 23:59 ` [PATCH 2/8] cgroup: relocate cgroup_rm_cftypes() Tejun Heo
2014-01-28 23:59 ` Tejun Heo
2014-01-28 23:59 ` [PATCH 3/8] cgroup: remove cftype_set Tejun Heo
2014-01-28 23:59 ` Tejun Heo
2014-01-28 23:59 ` [PATCH 4/8] cgroup: simplify dynamic cftype addition and removal Tejun Heo
2014-01-28 23:59 ` Tejun Heo
2014-01-28 23:59 ` [PATCH 5/8] cgroup: make cgroup hold onto its kernfs_node Tejun Heo
2014-01-28 23:59 ` [PATCH 6/8] cgroup: remove cgroup->name Tejun Heo
2014-01-28 23:59 ` Tejun Heo
[not found] ` <1390953585-16554-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-01-29 10:47 ` Peter Zijlstra [this message]
2014-01-29 10:47 ` Peter Zijlstra
2014-01-29 12:09 ` Michal Hocko
2014-01-29 12:09 ` Michal Hocko
2014-01-29 12:09 ` Michal Hocko
[not found] ` <20140129120907.GA22183-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2014-01-29 15:25 ` Tejun Heo
2014-01-29 15:25 ` Tejun Heo
2014-01-29 16:06 ` [PATCH v2 " Tejun Heo
2014-01-29 16:06 ` Tejun Heo
2014-01-29 16:06 ` Tejun Heo
2014-01-28 23:59 ` [PATCH 7/8] cgroup: rename cgroupfs_root->number_of_cgroups to ->nr_cgrps and make it atomic_t Tejun Heo
2014-01-28 23:59 ` Tejun Heo
2014-01-28 23:59 ` [PATCH 8/8] cgroup: remove cgroupfs_root->refcnt Tejun Heo
2014-01-28 23:59 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2014-02-08 16:38 [PATCHSET v2 cgroup/for-3.15] cgroup: cleanups after kernfs conversion Tejun Heo
2014-02-08 16:38 ` [PATCH 6/8] cgroup: remove cgroup->name Tejun Heo
[not found] ` <1391877509-10855-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-02-12 7:52 ` Li Zefan
2014-02-12 7:52 ` Li Zefan
[not found] ` <52FB2834.3090408-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-02-12 8:27 ` Tejun Heo
2014-02-12 8:27 ` Tejun Heo
[not found] ` <20140212082713.GD7984-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-02-12 8:52 ` Li Zefan
2014-02-12 8:52 ` Li Zefan
2014-02-12 8:52 ` Li Zefan
[not found] ` <1391877509-10855-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-02-08 16:38 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129104712.GD9636@twins.programming.kicks-ass.net \
--to=peterz-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.