From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 6/8] cgroup: remove cgroup->name Date: Wed, 29 Jan 2014 11:47:12 +0100 Message-ID: <20140129104712.GD9636@twins.programming.kicks-ass.net> References: <1390953585-16554-1-git-send-email-tj@kernel.org> <1390953585-16554-7-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1390953585-16554-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Hocko , Johannes Weiner , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar On Tue, Jan 28, 2014 at 06:59:43PM -0500, Tejun Heo wrote: > cgroup->name handling became quite complicated over time involving > dedicated struct cgroup_name for RCU protection. Now that cgroup is > on kernfs, we can drop all of it and simply use kernfs_name/path() and > friends. Replace cgroup->name and all related code with kernfs > name/path constructs. > > * Reimplement cgroup_name() and cgroup_path() as thin wrappers on top > of kernfs counterparts, which involves semantic changes. > pr_cont_cgroup_name() and pr_cont_cgroup_path() added. > > * cgroup->name handling dropped from cgroup_rename(). > > * All users of cgroup_name/path() updated to the new semantics. Users > which were formatting the string just to printk them are converted > to use pr_cont_cgroup_name/path() instead, which simplifies things > quite a bit. As cgroup_name() no longer requires RCU read lock > around it, RCU lockings which were protecting only cgroup_name() are > removed. > > Signed-off-by: Tejun Heo > Cc: Li Zefan > Cc: Ingo Molnar > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki Acked-by: Peter Zijlstra From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751906AbaA2Kr1 (ORCPT ); Wed, 29 Jan 2014 05:47:27 -0500 Received: from merlin.infradead.org ([205.233.59.134]:47201 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbaA2KrX (ORCPT ); Wed, 29 Jan 2014 05:47:23 -0500 Date: Wed, 29 Jan 2014 11:47:12 +0100 From: Peter Zijlstra To: Tejun Heo Cc: lizefan@huawei.com, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki Subject: Re: [PATCH 6/8] cgroup: remove cgroup->name Message-ID: <20140129104712.GD9636@twins.programming.kicks-ass.net> References: <1390953585-16554-1-git-send-email-tj@kernel.org> <1390953585-16554-7-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1390953585-16554-7-git-send-email-tj@kernel.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 28, 2014 at 06:59:43PM -0500, Tejun Heo wrote: > cgroup->name handling became quite complicated over time involving > dedicated struct cgroup_name for RCU protection. Now that cgroup is > on kernfs, we can drop all of it and simply use kernfs_name/path() and > friends. Replace cgroup->name and all related code with kernfs > name/path constructs. > > * Reimplement cgroup_name() and cgroup_path() as thin wrappers on top > of kernfs counterparts, which involves semantic changes. > pr_cont_cgroup_name() and pr_cont_cgroup_path() added. > > * cgroup->name handling dropped from cgroup_rename(). > > * All users of cgroup_name/path() updated to the new semantics. Users > which were formatting the string just to printk them are converted > to use pr_cont_cgroup_name/path() instead, which simplifies things > quite a bit. As cgroup_name() no longer requires RCU read lock > around it, RCU lockings which were protecting only cgroup_name() are > removed. > > Signed-off-by: Tejun Heo > Cc: Li Zefan > Cc: Ingo Molnar > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki Acked-by: Peter Zijlstra