From: Jenny Tc <jenny.tc@intel.com>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kim Milo" <Milo.Kim@ti.com>, "Lee Jones" <lee.jones@linaro.org>,
"Jingoo Han" <jg1.han@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Sachin Kamat" <sachin.kamat@linaro.org>,
"Rupesh Kumar" <rupesh.kumar@stericsson.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
"Rhyland Klein" <rklein@nvidia.com>,
"Pavel Machek" <pavel@ucw.cz>,
"David Woodhouse" <dwmw2@infradead.org>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Sebastian Reichel" <sre@ring0.de>,
"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>,
"freemangordon@abv.bg" <freemangordon@abv.bg>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Anton Vorontsov" <anton@enomsg.org>
Subject: Re: [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props
Date: Wed, 29 Jan 2014 18:38:25 +0530 [thread overview]
Message-ID: <20140129130825.GA15355@jenny-desktop> (raw)
In-Reply-To: <52E285DF.5020708@gmail.com>
On Fri, Jan 24, 2014 at 08:25:19AM -0700, Dmitry Eremin-Solenikov wrote:
> On 22/01/14 21:19, Jenny TC wrote:
> > Add new power supply properties for input current, charge termination
> > current, min and max temperature
> >
> > POWER_SUPPLY_PROP_TEMP_MIN - minimum operatable temperature
> > POWER_SUPPLY_PROP_TEMP_MAX - maximum operatable temperature
>
> What is the difference from TEMP_ALERT_MIN/TEMP_ALERT_MAX ?
> There is a difference in definitions, but what is the logical difference?
TEMP_ALERT_MIN/MAX is to ALERT when temperature cross the threshold.
TEMP_MIN/MAX is to stop charging/discharging when cross the threshold.
>
> > POWER_SUPPLY_PROP_INLMT - input current limit programmed by charger. Indicates
> > the input current for a charging source.
> > POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect
> > the end of charge condition
>
> For both of them:
>
> 1) Please don't use obscure abbreviations
Agreed
> 2) Is this generic enough? I.e. besides your charge manager who will
> use that?
Generic and all charger drivers can use this.
> > --
> With best wishes
> Dmitry
-Jenny
next prev parent reply other threads:[~2014-01-29 5:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 17:19 [PATCH v3 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-01-22 17:19 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-01-23 9:00 ` Jingoo Han
2014-01-24 13:01 ` Pavel Machek
2014-01-24 15:25 ` Dmitry Eremin-Solenikov
2014-01-29 13:08 ` Jenny Tc [this message]
2014-01-22 17:19 ` [PATCH 2/4] power_supply: Introduce Generic Power Supply charging driver Jenny TC
2014-01-25 17:04 ` Pavel Machek
2014-01-29 19:13 ` Jenny Tc
2014-01-22 17:19 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-01-25 22:29 ` Pavel Machek
2014-01-22 17:19 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-01-23 8:58 ` Jingoo Han
2014-01-25 22:30 ` Pavel Machek
2014-01-28 14:14 ` Pavel Machek
2014-01-29 13:23 ` Jenny Tc
2014-01-29 7:26 ` Jingoo Han
2014-01-29 9:36 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2014-01-30 17:30 [PATCH v4 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-01-30 17:30 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-02-04 5:12 [PATCH v5 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-02-04 5:12 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-02-20 5:53 [PATCH v6 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-02-20 5:53 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-06-19 14:02 [PATCHv9 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-06-19 14:02 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-06-30 9:55 [PATCHv10 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-06-30 9:55 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-07-03 13:05 ` Sebastian Reichel
2014-07-08 6:04 [PATCHv11 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-07-08 6:04 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-07-14 13:05 ` Pavel Machek
2014-07-17 23:34 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129130825.GA15355@jenny-desktop \
--to=jenny.tc@intel.com \
--cc=Milo.Kim@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=anton@enomsg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=freemangordon@abv.bg \
--cc=jg1.han@samsung.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=rklein@nvidia.com \
--cc=rupesh.kumar@stericsson.com \
--cc=sachin.kamat@linaro.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.