From: Simon Wunderlich <sw@simonwunderlich.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Sujith Manoharan <sujith@msujith.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix IBSS join
Date: Wed, 29 Jan 2014 13:19:03 +0100 [thread overview]
Message-ID: <201401291319.03802.sw@simonwunderlich.de> (raw)
In-Reply-To: <1390997315.4143.4.camel@jlt4.sipsolutions.net>
> On Tue, 2014-01-28 at 07:24 +0530, Sujith Manoharan wrote:
> > - ieee80211_ibss_disconnect(sdata);
> > + ieee80211_ibss_disconnect(sdata, false);
>
> I'm not sure why you'd want to have 'false' here? If the network is
> switching channel, then the old BSS entry is useless, no?
In the CSA case the BSS is still used, we modify the BSS entry in
ieee80211_ibss_finish_csa() (which is not really clean, but done by all the
current CSA code).
Since the BSS is changed and the node continues to beacon, I think that's ok
to do it like Sujith proposed.
Cheers,
Simon
next prev parent reply other threads:[~2014-01-29 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 1:54 [PATCH] mac80211: Fix IBSS join Sujith Manoharan
2014-01-28 14:42 ` Simon Wunderlich
2014-01-29 12:08 ` Johannes Berg
2014-01-29 12:19 ` Simon Wunderlich [this message]
2014-01-30 7:35 ` Sujith Manoharan
2014-01-30 8:10 ` Johannes Berg
2014-01-30 10:58 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401291319.03802.sw@simonwunderlich.de \
--to=sw@simonwunderlich.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.