From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1W8XM0-00068E-Ll
	for qemu-devel@nongnu.org; Wed, 29 Jan 2014 10:47:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1W8XLv-0003Sk-MZ
	for qemu-devel@nongnu.org; Wed, 29 Jan 2014 10:47:04 -0500
Received: from paradis.irqsave.net ([62.212.105.220]:48626)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1W8XLv-0003SV-D9
	for qemu-devel@nongnu.org; Wed, 29 Jan 2014 10:46:59 -0500
Date: Wed, 29 Jan 2014 16:46:57 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140129154657.GE3079@irqsave.net>
References: <1391009634-21107-1-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1391009634-21107-1-git-send-email-stefanha@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>

Le Wednesday 29 Jan 2014 =E0 16:33:54 (+0100), Stefan Hajnoczi a =E9crit =
:
> The 071 test is designed for IMGFMT=3Dqcow2 because it uses the l2_load
> blkdebug event.  Its output filtering also assumes that IMGFMT is not
> raw since 071.out contains "format=3Draw" but IMGFMT=3Draw would filter=
 the
> output to "format=3DIMGFMT".
>=20
> Perhaps the test case can be rewritten to be more generic, but for now
> let's document that it was only supposed to work with qcow2.
>=20
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qemu-iotests/071 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/071
> index 2a22546..dbc07c6 100755
> --- a/tests/qemu-iotests/071
> +++ b/tests/qemu-iotests/071
> @@ -38,7 +38,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>  . ./common.rc
>  . ./common.filter
> =20
> -_supported_fmt generic
> +_supported_fmt qcow2
>  _supported_proto generic
>  _supported_os Linux
> =20
> --=20
> 1.8.5.3
>=20
>=20
Reviewed-by: Benoit Canet <benoit@irqsave.net>