From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] libxl: add option for discard support to xl disk configuration Date: Wed, 29 Jan 2014 19:24:42 +0100 Message-ID: <20140129182442.GA12903@aepfle.de> References: <1390933497-12819-1-git-send-email-olaf@aepfle.de> <1390991329.31814.58.camel@kazak.uk.xensource.com> <20140129111939.GA26899@aepfle.de> <1390995947.31814.79.camel@kazak.uk.xensource.com> <20140129142357.GA27051@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140129142357.GA27051@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Jan 29, Olaf Hering wrote: > On Wed, Jan 29, Ian Campbell wrote: > > On Wed, 2014-01-29 at 12:19 +0100, Olaf Hering wrote: > > > Thats what I'm asking you. Why is readwrite set here, and later on also > > > in the .l file? At least just setting it here did not unconditionally > > > enable it if no discard= was specified. I have not traced the code why > > > that happens. > > > > One for Ian J I think. Perhaps it is just setting the default? > > For some reason this setting is lost, at least for my discard flag. The > readwrite part may suffer from the same issue, otherwise access_set > could be removed. I will trace the code to understand how it works. I think the failure was caused by incompatibility between libxl.so and xl because I did just copy libs around. Its working fine with a fresh rpm package. I will remove the discard_set variable. Olaf