From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jenny Tc <jenny.tc@intel.com>
Subject: Re: [PATCH 2/4] power_supply: Introduce Generic Power Supply
 charging driver
Date: Thu, 30 Jan 2014 00:43:24 +0530
Message-ID: <20140129191324.GC15355@jenny-desktop>
References: <1390411194-21410-1-git-send-email-jenny.tc@intel.com>
 <1390411194-21410-3-git-send-email-jenny.tc@intel.com>
 <20140125170402.GA27959@Nokia-N900>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20140125170402.GA27959@Nokia-N900>
Sender: linux-kernel-owner@vger.kernel.org
To: Pavel Machek <pavel@ucw.cz>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>, Anton Vorontsov <cbouatmailru@gmail.com>, Anton Vorontsov <anton.vorontsov@linaro.org>, Kim Milo <Milo.Kim@ti.com>, Lee Jones <lee.jones@linaro.org>, Jingoo Han <jg1.han@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Sachin Kamat <sachin.kamat@linaro.org>, Rupesh Kumar <rupesh.kumar@stericsson.com>, Lars-Peter Clausen <lars@metafoo.de>, Pali Roh?r <pali.rohar@gmail.com>, Mark Brown <broonie@opensource.wolfsonmicro.com>, Rhyland Klein <rklein@nvidia.com>, David Woodhouse <dwmw2@infradead.org>, Tony Lindgren <tony@atomide.com>, Russell King <linux@arm.linux.org.uk>, Sebastian Reichel <sre@ring0.de>, "aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>, "freemangordon@abv.bg" <freemangordon@abv.bg>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
List-Id: linux-omap@vger.kernel.org

On Sat, Jan 25, 2014 at 10:04:03AM -0700, Pavel Machek wrote:
> > +	* Write access using set_property
> > +		* Set Maximum charging current
> > +		* Action: Configure safety charging registers if any. If not no
> > +			  actions expected for this.
> 
> Having property that does nothing sounds evil to me.

No h/w actions expected. But driver action expected. Will fix in next patch set

> > +* POWER_SUPPLY_CHARGER_PROP_ENABLE_CHARGING
> > +	* Write access using set_property
> > +		* Enable/Disable charging. Charger supplies power to platform,
> > +		  but charging is disabled
> 
> This is unclear. Charging is always disabled?

Writing 0, disables charger. Writing 1 enables charging. 

-Jenny