From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Add Baytrail PSR Support. Date: Wed, 29 Jan 2014 20:21:41 +0100 Message-ID: <20140129192141.GK7444@phenom.ffwll.local> References: <20140129131251.GA28110@nuc-i3427.alporthouse.com> <1391007335-8698-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by gabe.freedesktop.org (Postfix) with ESMTP id C6E8B11DA6E for ; Wed, 29 Jan 2014 11:21:45 -0800 (PST) Received: by mail-ea0-f182.google.com with SMTP id r15so1149559ead.41 for ; Wed, 29 Jan 2014 11:21:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <1391007335-8698-1-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 29, 2014 at 12:55:35PM -0200, Rodrigo Vivi wrote: > This patch adds PSR Support to Baytrail. > > Baytrail cannot easily detect screen updates and force PSR exit. > So we inactivate it on {busy_ioctl, sw_finish and mark_busy} > and update to enable it back on next display mark_idle. > > v2: Also inactivate PSR on cursor update. > v3: Inactivate PSR on mark_busy, dset_domain and sw_finish_ioctl, and > early on page flip besides avoid initializing inactive/active flag > more than once. > v4: Fix identation issues. > v5: Rebase and add Baytrail per pipe support although leaving PIPE_B > support disabled by for now since it isn't working properly yet. > v6: Removing forgotten comment and useless clkgating definition. > v7: Remove inactivate from set_domain. Chris warned this was semanticaly > wrong. Like I've said I agree that it's not pretty, but I also think it's the only thing we can do atm. For fbc we have the hardware-based fence tracking, but it sounds like that's busted for psr on byt. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch