All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: iptables-xml segfault if missing -A
Date: Wed, 29 Jan 2014 20:23:44 +0100	[thread overview]
Message-ID: <20140129192344.GA15750@localhost> (raw)
In-Reply-To: <20140124060658.GA25711@home>

On Thu, Jan 23, 2014 at 10:06:58PM -0800, Phil Oester wrote:
> As pointed out by Bernhard Reutner-Fischer, a malformed line fed to
> iptables-xml such as the below with a missing space after the -A:
> 
> 	-APOSTROUTING -d 1.1.1.1/32 -p tcp -j MASQUERADE
> 
> causes a segfault.  Patch attached.
> 
> This closes netfilter bugzilla #886.

Applied, thanks.

      reply	other threads:[~2014-01-29 19:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24  6:06 [PATCH] iptables: iptables-xml segfault if missing -A Phil Oester
2014-01-29 19:23 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140129192344.GA15750@localhost \
    --to=pablo@netfilter.org \
    --cc=kernel@linuxace.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.