From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joby Poriyath Subject: Re: [PATCH] xen/pygrub: grub2/grub.cfg from RHEL 7 has new commands in menuentry. Date: Thu, 30 Jan 2014 14:55:47 +0000 Message-ID: <20140130145547.GA5100@citrix.com> References: <20140130113126.GA3326@citrix.com> <52EA3B67.2070707@citrix.com> <20140130120107.GA3441@citrix.com> <1391083654.29487.21.camel@kazak.uk.xensource.com> <20140130130241.GB3441@citrix.com> <1391090818.29487.36.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1391090818.29487.36.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andrew Cooper , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, Jan 30, 2014 at 02:06:58PM +0000, Ian Campbell wrote: > > > Perhaps ["\']([^"\']*)["\'] is more accurate (i.e. disallow quotes in > > > the name itself, although you might have to split into handling " and ' > > > separately to be more correct > > Any thoughts on this? The two regexes seems to be equivalent. My only worry with '.*?' was compatibility with older python. Luckily, it's supported in Python 2.2 and later. > > I suppose it depends a bit on the rules for mixing quotes in grub, e.g. > is > menuentry "Ian's super cool Linux" > > allowed. > > On the other hand pygrub is very much best effort so as long as it works > with the current set of inputs which we are aware of then .*? is fine. > Ok. Should I send an updated patch along with an example of RHEL 7 grub.cfg or is this patch acceptable as it is? Thanks, Joby