All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: ensure correct timestamp updates from truncate
Date: Thu, 30 Jan 2014 09:47:01 -0600	[thread overview]
Message-ID: <20140130154701.GP1935@sgi.com> (raw)
In-Reply-To: <20140130080652.GA23758@infradead.org>

On Thu, Jan 30, 2014 at 12:06:52AM -0800, Christoph Hellwig wrote:
> The VFS doesn't set the proper ATTR_CTIME and ATTR_MTIME values for truncate,
> so filesystems have to manually add them.  The introduction of
> xfs_setattr_time accidentally broke this special case an caused a
> regression in generic/313.  Fix this by removing the local mask variable
> in xfs_setattr_size so that we only have a single place to keep the
> attribute information.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>

That is v3.13-rc2-14-gc91c46c, so I believe we'll want to Cc: stable on this
one.  Correct?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2014-01-30 15:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-10 12:27 [xfs] c91c46c12: xfstests generic/313 regression fengguang.wu
2014-01-10 12:27 ` fengguang.wu
2014-01-10 13:22 ` Jeff Liu
2014-01-10 13:22   ` Jeff Liu
2014-01-10 13:33   ` Christoph Hellwig
2014-01-10 13:33     ` Christoph Hellwig
2014-01-10 14:01     ` Jeff Liu
2014-01-10 14:01       ` Jeff Liu
2014-01-11 11:10       ` Christoph Hellwig
2014-01-11 11:10         ` Christoph Hellwig
2014-01-29 13:13         ` Brian Foster
2014-01-29 16:35           ` Christoph Hellwig
2014-01-30  8:06           ` [PATCH] xfs: ensure correct timestamp updates from truncate Christoph Hellwig
2014-01-30  8:33             ` Jeff Liu
2014-01-30 13:57             ` Brian Foster
2014-01-30 15:47             ` Ben Myers [this message]
2014-02-03 10:23               ` Christoph Hellwig
2014-02-08  7:11                 ` Christoph Hellwig
2014-02-16 14:45                   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140130154701.GP1935@sgi.com \
    --to=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.