From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: nouveau: treat nv04_devinit_priv.owner as signed. Date: Thu, 30 Jan 2014 12:21:05 -0500 Message-ID: <20140130172105.GA1834@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A88C102040 for ; Thu, 30 Jan 2014 09:21:17 -0800 (PST) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: bskeggs@redhat.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is set and compared to -1 in the code, which evaluates to always false. If we want to treat it as a signed var, we should declare it as one. Signed-off-by: Dave Jones diff --git a/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h b/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h index 23470a57510c..9d54c106dddf 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h +++ b/drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.h @@ -5,7 +5,7 @@ struct nv04_devinit_priv { struct nouveau_devinit base; - u8 owner; + s8 owner; }; int nv04_devinit_ctor(struct nouveau_object *, struct nouveau_object *,