All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Update MySQL client package
Date: Thu, 30 Jan 2014 22:07:22 +0100	[thread overview]
Message-ID: <20140130220722.142e4aa1@skate> (raw)
In-Reply-To: <20140119115124.GA3387@free.fr>

Dear Yann E. MORIN,

On Sun, 19 Jan 2014 12:51:24 +0100, Yann E. MORIN wrote:

> >         depends on BR2_USE_MMU
> >         depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> > +
> > +if BR2_PACKAGE_MYSQL
> > +
> > +config BR2_PACKAGE_MYSQL_CLIENT
> > +        bool "MySQL client"
> > +
> > +config BR2_PACKAGE_MYSQL_CLIENT_SERVER
> > +       bool "MySQL server"
> > +
> > +endif
> 
> What if neither the client nor the server is selected? Does that make
> sense? If not, then always build the client (as we currently do), and
> make the server an option (as you did in your previous patch).

I would suggest:

config BR2_PACKAGE_MYSQL
	bool "mysql"
	select BR2_PACKAGE_MYSQL_CLIENT if !BR2_PACKAGE_MYSQL_SERVER

if BR2_PACKAGE_MYSQL

config BR2_PACKAGE_MYSQL_CLIENT
	bool "client"

config BR2_PACKAGE_MYSQL_SERVER
	bool "server"

endif

This way, we guarantee that at least either the client or the server
are enabled.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-01-30 21:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 21:24 [Buildroot] [PATCH 2/2] Update MySQL client package Marcelo Gutierrez
2014-01-19 11:51 ` Yann E. MORIN
2014-01-30 21:07   ` Thomas Petazzoni [this message]
2014-02-01 23:02     ` Marcelo Gutierrez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140130220722.142e4aa1@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.