From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/6] *.mk: replace (TARGET|HOST)_PATH by BR2_PATH
Date: Fri, 31 Jan 2014 09:31:04 +0100 [thread overview]
Message-ID: <20140131093104.5afcf411@skate> (raw)
In-Reply-To: <1391114333-28001-4-git-send-email-s.martin49@gmail.com>
Dear Samuel Martin,
On Thu, 30 Jan 2014 21:38:50 +0100, Samuel Martin wrote:
> Thanks to the 2 previous patches of the series, BR2_PATH conatins
conatins -> contains
> diff --git a/package/bustle/bustle.mk b/package/bustle/bustle.mk
> index 2330c08..c488dfa 100644
> --- a/package/bustle/bustle.mk
> +++ b/package/bustle/bustle.mk
> @@ -11,7 +11,7 @@ BUSTLE_LICENSE_FILES = LICENSE
> BUSTLE_DEPENDENCIES = libglib2 libpcap host-pkgconf
>
> define BUSTLE_BUILD_CMDS
> - PATH=$(TARGET_PATH) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> + PATH=$(BR2_PATH) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
This should rather be changed to:
$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS)
since TARGET_MAKE_ENV contains the proper definition for PATH. This
change could be done as a preparation commit.
> @@ -11,7 +11,7 @@ LIBHID_INSTALL_STAGING = YES
> LIBHID_AUTORECONF = YES
> # configure runs libusb-config for cflags/ldflags. Ensure it picks up
> # the target version
> -LIBHID_CONF_ENV = PATH=$(STAGING_DIR)/usr/bin:$(TARGET_PATH)
> +LIBHID_CONF_ENV = PATH=$(STAGING_DIR)/usr/bin:$(BR2_PATH)
Having $(STAGING_DIR)/usr/bin in the PATH looks really wrong. Instead
of doing that, we should point libhid configure script to the
libusb-config script by fixing m4/md_check_libusb018b.m4.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-31 8:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 20:38 [Buildroot] [PATCH v3 0/6] PATH cleanup Samuel Martin
2014-01-30 20:38 ` [Buildroot] [PATCH v3 1/6] Makefile: introduce BR2_PATH Samuel Martin
2014-01-31 8:25 ` Thomas Petazzoni
2014-01-31 8:41 ` Jeremy Rosen
2014-01-31 9:08 ` Thomas Petazzoni
2014-01-31 10:13 ` Samuel Martin
2014-01-30 20:38 ` [Buildroot] [PATCH v3 2/6] Makefile: add $(HOST_DIR)/sbin to BR2_PATH Samuel Martin
2014-01-31 8:25 ` Thomas Petazzoni
2014-01-30 20:38 ` [Buildroot] [PATCH v3 3/6] *.mk: replace (TARGET|HOST)_PATH by BR2_PATH Samuel Martin
2014-01-31 8:31 ` Thomas Petazzoni [this message]
2014-01-30 20:38 ` [Buildroot] [PATCH v3 4/6] infra: remove unused {TARGET, HOST}_PATH definition Samuel Martin
2014-01-30 20:38 ` [Buildroot] [PATCH v3 5/6] pkg-cmake.mk: add PATH in the configure command environment Samuel Martin
2014-01-30 20:38 ` [Buildroot] [PATCH v3 6/6] Makefile: export PATH Samuel Martin
2014-01-31 8:33 ` Thomas Petazzoni
2014-02-04 9:05 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131093104.5afcf411@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.