From: Stanislaw Gruszka <sgruszka@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
Ben Guthro <benjamin.guthro@citrix.com>,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
xen-devel@lists.xensource.com
Subject: Re: [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor]
Date: Fri, 31 Jan 2014 15:04:51 +0100 [thread overview]
Message-ID: <20140131140451.GB7648@redhat.com> (raw)
In-Reply-To: <20140129082521.GA1362@redhat.com>
On Wed, Jan 29, 2014 at 09:25:21AM +0100, Stanislaw Gruszka wrote:
> > Looks incomplete, what about the kzalloc() in
> > xen_upload_processor_pm_data() and kcalloc()s in check_acpi_ids()?
>
> Indeed and additionally from check_acpi_ids() we call
> acpi_walk_namespace(), which also take mutexes. Hence unfortunately
> making xen_upload_processor_pm_data() atomic is not easy, but possibly
> can be done by saving some data in memory after initialization.
>
> Or perhaps this problem can be solved differently, by not using
> yscore_ops->resume(), but some other resume callback from core, which
> allow to sleep. Than can require registering dummy device or sysfs
> class, but maybe there are simpler solutions.
Eventually work_struct could be used and scheduled from ->resume()
callback, if there is no dependency between uploading processor PM
data to hypervisor and other actions performed after
syscore_ops->resume();
Thanks
Stanislaw
next prev parent reply other threads:[~2014-01-31 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 15:08 [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor] Stanislaw Gruszka
2014-01-28 16:04 ` Konrad Rzeszutek Wilk
2014-01-29 5:24 ` David Rientjes
2014-01-29 8:25 ` Stanislaw Gruszka
2014-01-31 14:04 ` Stanislaw Gruszka [this message]
2014-01-31 16:01 ` Konrad Rzeszutek Wilk
2014-02-03 10:12 ` Stanislaw Gruszka
2014-02-03 14:14 ` Konrad Rzeszutek Wilk
2014-02-10 14:37 ` Konrad Rzeszutek Wilk
2014-02-26 10:26 ` Stanislaw Gruszka
2014-02-26 10:30 ` [PATCH] xen/acpi-processor: fix enabling interrupts on syscore_resume Stanislaw Gruszka
2014-03-14 17:14 ` [BUG?] Interrupts enabled after xen_acpi_processor_resume+0x0/0x34 [xen_acpi_processor] Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131140451.GB7648@redhat.com \
--to=sgruszka@redhat.com \
--cc=benjamin.guthro@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.