Re: [PATCH 2/2] ASoC: arizona: Improve ultrasonic frequency response

[Charles Keepax <ckeepax@opensource.wolfsonmicro.com>]

On Fri, Jan 31, 2014 at 04:06:44PM +0000, Mark Brown wrote:
> On Fri, Jan 31, 2014 at 03:47:14PM +0000, Charles Keepax wrote:
> > Evaluation of the device has given some settings to improve the
> > ultrasonic frequency response. This patch allows the user the option of
> > applying those.
> 
> Why would the user ever not want to do this?
> 
> > +	switch (priv->arizona->type) {
> > +	case WM5102:
> > +		if (priv->arizona->pdata.ultrasonic_response) {
> > +			snd_soc_write(codec, 0x80, 0x3);
> > +			if (params_rate(params) >= 176400)
> > +				snd_soc_write(codec, 0x4dd, 0x1);
> > +			else
> > +				snd_soc_write(codec, 0x4dd, 0x0);
> > +			snd_soc_write(codec, 0x80, 0x0);
> > +		}
> > +		break;
> 
> The code is only changing the configuration when the user is actually
> using ultrasonic sample rates so it doesn't seem like it should have a
> detrimental effect on other configurations.

Apologies I should have included a bit more in the commit message
I think, I will fire out a quick respin.

Thanks,
Charles